Update feature-external-dicts #578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2023
|
Why has this PR been open for a year, and why has external dicts support not been merged into the main app? We shouldn't have to use https://github.com/Helium314/openboard/releases for this feature. |
Helium314
added a commit
to Helium314/HeliBoard
that referenced
this pull request
Jun 26, 2023
openboard-team/openboard#569 openboard-team/openboard#578 modified so dictionaries use the correct type instead of always main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some problems getting dictionaries to the correct folder, and some issues with mixed- and lower case locales strings.
Also "categories" for dictionaries can now be separated by
_, which allows for proper detection and usage of additional dictionaries (e.g. for emojis) as long as the category is unique.Looks like categories are not used for anything except detecting
maincategory to decide whether to load built-in main dictionary.