Refactor/bounty #171
Open
Refactor/bounty #171
+601
−583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
先拉取最新代码处理下冲突 |
# Conflicts: # src/app/bounties/[id]/Activities.js # src/app/bounties/[id]/page.js
|
@missop is attempting to deploy a commit to the OpenBuild Team on Vercel. A member of the Team first needs to authorize it. |
|
已经合并成功 |
|
已经转移到其他文件中留在原文件中的代码，确定不再用了就删掉，而非注释。想日后找历史代码就从提交记录里找。 |
|
好
在 2025年3月20日星期四，Ourai L. ***@***.***> 写道：
… 已经转移到其他文件中留在原文件中的代码，确定不再用了就删掉，而非注释。想日后找历史代码就从提交记录里找。
—
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2NA655457SG2TP5QU2ZRT2VIXXFAVCNFSM6AAAAABZCN6LNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZZGAZDSMZRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: ourai]*ourai* left a comment (openbuildxyz/openbuild-frontend#171)
<#171 (comment)>
已经转移到其他文件中留在原文件中的代码，确定不再用了就删掉，而非注释。想日后找历史代码就从提交记录里找。
—
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2NA655457SG2TP5QU2ZRT2VIXXFAVCNFSM6AAAAABZCN6LNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZZGAZDSMZRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ourai
requested changes
Mar 21, 2025
src/domain/bounty/views/applied-builder-list/AppliedBuilderList.js
Outdated
Show resolved
Hide resolved
src/domain/bounty/views/applied-builder-list/AppliedBuilderList.js
Outdated
Show resolved
Hide resolved
src/domain/bounty/views/applied-builder-list/AppliedBuilderList.js
Outdated
Show resolved
Hide resolved
src/domain/bounty/views/applied-builder-list/AppliedBuilderList.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
这个文件可以直接移动到 domain/bounty/views/process-list 下，并且在 ProcessList 中使用，revalidatePathAction 作为组件属性传入。
There was a problem hiding this comment.
因为那是个用到了 Next.js 机制的 server action
There was a problem hiding this comment.
这个文件没有被多次引用，为何要放在 widgets 下面？
There was a problem hiding this comment.
判断是不是个视图（view）的标准，是相应的数据源是否为实体，这里 process list 实际上是个字典或枚举值。不符合视图条件的就放进 widgets。
| import { useBountyEnvCheck } from '#/domain/bounty/hooks'; | ||
| import { useUser } from '#/state/application/hooks'; | ||
|
|
||
| function ProcessListView({process=[],data={},setAppliedModalOpen,setApplyFinishedModalOpen,setAgreeFinishedModalOpen}) { |
There was a problem hiding this comment.
把 ApplyFinishedModal、AppliedModal、ApplyFinishedModal 都挪到同级文件夹下，对话框显示状态在这个组件里管理，并且 revalidatePathAction 作为组件属性传入
ourai
requested changes
Mar 22, 2025
| import { EXPERIENCE_OPTIONS } from '#/lib/user'; | ||
| import { denyBuilder } from '#/services/creator'; | ||
| import { useConfig, useMediaUrl } from '#/state/application/hooks'; | ||
|
|
||
| function AppliedBuilderListView({data,isLoading,setCurrUser,setConfirmModalOpen,setApproveConfirmIds}) { | ||
| function AppliedBuilderListView({data,approve}) { |
There was a problem hiding this comment.
原则上来讲，UI 组件的属性不应该有函数，但 React 里没有 Vue 那种事件机制，所以用 on- 开头命名的函数视为事件，所以这个应该叫 onApprove。
| import { BountyABI } from '@/constants/abis/bounty'; | ||
| import { BOUNTY_SUPPORTED_CHAIN } from '@/constants/chain'; | ||
| import { contracts, payTokens } from '@/constants/contract'; | ||
| import { useAllowance, useApprove } from '@/hooks/useERC20'; | ||
| import { fetcher } from '@/utils/request'; | ||
| import { parseTokenUnits } from '@/utils/web3'; | ||
|
|
||
| import { useBountyEnvCheck } from '#/domain/bounty/hooks'; | ||
| import AppliedBuilderListView from '#/domain/bounty/views/applied-builder-list'; |
| <div className="max-h-[400px] overflow-auto"> | ||
| <AppliedBuilderListView | ||
| data={data} | ||
| isLoading={isLoading} |
| import { BountyABI } from '@/constants/abis/bounty'; | ||
| import { BOUNTY_SUPPORTED_CHAIN } from '@/constants/chain'; | ||
| import { contracts, payTokens } from '@/constants/contract'; | ||
| import { useAllowance, useApprove } from '@/hooks/useERC20'; | ||
| import { fetcher } from '@/utils/request'; | ||
| import { parseTokenUnits } from '@/utils/web3'; | ||
|
|
||
| import { useBountyEnvCheck } from '#/domain/bounty/hooks'; |
| @@ -23,17 +23,12 @@ import { Modal } from '@/components/Modal'; | |||
| import { withdraw } from '@/constants/bounty'; | |||
|
|
|||
| import { useBountyEnvCheck } from '#/domain/bounty/hooks'; | |||
| @@ -28,9 +28,7 @@ import { parseTokenUnits, signBounty } from '@/utils/web3'; | |||
| import { useBountyEnvCheck } from '#/domain/bounty/hooks'; | |||
| import { revalidatePathAction } from '#/app/actions'; | ||
| import { AgreeFinishedModal } from '#/domain/bounty/widgets/process-list/AgreeFinishedModal'; | ||
| import { AppliedModal } from '#/domain/bounty/widgets/process-list/AppliedModal'; | ||
| import { ApplyFinishedModal } from '#/domain/bounty/widgets/process-list/ApplyFinishedModal'; | ||
| import { useUser } from '#/state/application/hooks'; |
|
|
||
| import { formatTime } from '@/utils/date'; | ||
|
|
||
| import { useBountyEnvCheck } from '#/domain/bounty/hooks'; | ||
| import { revalidatePathAction } from '#/app/actions'; |
There was a problem hiding this comment.
作为组件属性传入：
domain不允许引用app和entryrevalidatePathAction是 server action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.