feat: 个人主页信息与 Web3.bio Profile 数据融合改进 #178
Open
+176
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AsaoOoo0o0o is attempting to deploy a commit to the OpenBuild Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ourai
requested changes
Mar 21, 2025
| const baseUserDesc = data?.base.user_bio; | ||
| const web3BioDesc = data?.web3Bio?.find(v => v.description)?.description; | ||
| return baseUserDesc || web3BioDesc || '--'; | ||
| }, [data]); |
There was a problem hiding this comment.
- 复杂度低的纯计算不需要用
useMemo； - 计算过程没有强依赖组件内部状态，可以在组件外部定义函数。
| /> | ||
| <div className="relative"> | ||
| <Avatar | ||
| className="-mt-[104px] md:mt-0" |
| <Avatar | ||
| className="-mt-[104px] md:mt-0" | ||
| size={110} | ||
| src={data.base.user_avatar} |
There was a problem hiding this comment.
头像没有从 Web3bio 获取。
user_avatar 返回的路径中包含 /config/avatar 是系统默认头像，代表用户自己没设置过头像，这时尝试从 Web3bio 获取，如果没有就用系统默认的。
| alt="web3bio" | ||
| className="size-6 rounded-full absolute right-1 bottom-1 border-1 border-white" | ||
| /> | ||
| )} |
| const web3BioSocialKeyMap = { | ||
| user_github: 'github', | ||
| user_discord: 'discord', | ||
| user_twitter: 'x', |
| @@ -53,7 +69,7 @@ function SocialInfoWidget({ className, data }) { | |||
| const socials = useMemo( | |||
| () => | |||
| Object.keys(data.social) | |||
| .map(i => socialsInfo(i, data.social[i])) | |||
| .map(i => socialsInfo(i, data.social[i], web3BioLink(i, data))) | |||
There was a problem hiding this comment.
web3BioLink 这个函数不需要：
- 函数里第一行的
reduce应该拿出来在数组遍历操作（map）前计算，以避免重复计算； - 函数里第二行作为
socialsInfo的第三个参数传进去。
| <div className="mt-6 text-xs flex gap-1"> | ||
| <p className="uppercase opacity-60 font-bold flex-1">Onchain Identities</p> | ||
| <div className="opacity-40">Built with</div> | ||
| <a className="" href={`https://web3.bio/${data.social.user_wallet}`} target="_blank" rel="noreferrer"> |
| <p className="uppercase opacity-60 font-bold flex-1">Onchain Identities</p> | ||
| <div className="opacity-40">Built with</div> | ||
| <a className="" href={`https://web3.bio/${data.social.user_wallet}`} target="_blank" rel="noreferrer"> | ||
| web3.bio |
| style={{ | ||
| borderColor: socialsConfig(k).color, | ||
| backgroundColor: socialsConfig(k).color, | ||
| }} |
There was a problem hiding this comment.
设计图上边框和背景色不一样吧？另外，用 Tailwind CSS class 的形式设置
| @@ -36,18 +35,65 @@ function resolveLinks({ social, web3Bio = [] }) { | |||
| return web3Bio.reduce((p, c) => [].concat(p, filterExistsInOpenBuild(c.links, social)), []); | |||
| } | |||
|
|
|||
| function socialsConfig(type) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #169