Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Upload without subtitle-file or thumbnail-image fails with an error #408

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

chfsx
Copy link
Contributor

@chfsx chfsx commented Mar 6, 2025

This fixes issue #405, please have some tests. The changes are quite small, maybe a review is not necessary

@marcusm7
Copy link

marcusm7 commented Mar 6, 2025

I would say, that a real review isn't required. Two "If null"-control structures... :)

It works for me (Ilias 9.7).
#405 (comment)

@dagraf
Copy link

dagraf commented Mar 6, 2025

Thx for the fix (@chfsx) and for testing (@marcusm7).

Since both of you agree that no review is needed, @chfsx: Can you please merge this PR? Thx!

@chfsx
Copy link
Contributor Author

chfsx commented Mar 6, 2025

I wait till tomorrow and will bundle with #412 and #413 if i get a positive feedback as well

@chfsx chfsx merged commit fdb9c1e into opencast-ilias:release_9 Mar 10, 2025
@chfsx
Copy link
Contributor Author

chfsx commented Mar 10, 2025

This has been released with v9.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants