Add Create, Edit, Delete for LifeCycle Policies #1004

Arnei · 2024-12-04T09:56:34Z

Instead of only being able to view lifecycle policies, this commit lets you edit them, create new ones and even delete them.

Includes #943. Can serve to replace it.

Depends on changes to the backend: opencast/opencast#6139. These changes are currently pointed at develop.

To test this, you'll need an Opencast with backend changes mentioned above.

Demonstration:
Bildschirmaufzeichnung vom 2024-12-04 10-45-28.webm

github-actions · 2024-12-04T09:56:47Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2024-12-04T09:59:05Z

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1004

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1004

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Adds a new tab to recordings called "LifeCycle Policies". Much like other tabs this tab displays information on its subject in a table format. Unlike i.e. the events tab, the LifeCycle Policies cannot be changed in any way, just be viewed. Editing is supposed to be added at a later date. Depends on PR opencast/opencast#6139 being merged to make any sense. Similarly, if you would like to test this, your admin interface should point to an Opencast with the PR installed.

Type LifeCyclePolicy was missing on a union type.

Instead of only being able to view lifecycle policies, this commit lets you edit them, create new ones and even delete them. Depends on changes to the backend.

github-actions · 2024-12-04T11:03:10Z

This pull request is deployed at test.admin-interface.opencast.org/1004/2025-03-20_14-30-47/ .
It might take a few minutes for it to become available.

github-actions · 2024-12-11T08:33:59Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2024-12-12T11:36:10Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

LukasKalbertodt · 2024-12-17T11:02:04Z

I have some random UI-related notes that I took when @Arnei recently presented this PR to us internally.

I don't mind the "technical enum names" in the drop down menus, but I think the one enum could be improved. SPECIFIC_DATA -> ONCE? And ALWAYS also confuses me, maybe there is a better name for it as well.
Filters
- It wasn't clear to me whether its a "contains string" check or a "exact string match" or wildcard or regex, ... maybe add a short note or sth?
- For some field types (e.g. strings, like title) the "greater than" comparison makes little sense I think? Maybe hide it then?
- The label "Must" also confuses me, maybe rename that to "negate" or sth?
- Maybe add a note that the filters are ANDed together, i.e. all filters must match.
- Finally, I think one feature would be really nice, but is more work than anything I mentioned so far: it would be nice if the UI would show how many events currently match your filter. That gives you a lot more feedback. Maybe there can be a link that links to the admin UI event view with all those filters applied? Not sure if that's possible. Or even a link to the external API with those exact filters would be helpful in my opinion.

Other than that I had no complaints. Looked very finished and very like the other UIs in this project.

majosch · 2024-12-18T09:00:13Z

@Arnei I just tried to spin up a test container via podman as noticed above, but unfortunately it fails to start:

~$ podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1004

> [email protected] start
> vite --host 0.0.0.0

/admin-interface/node_modules/rollup/dist/native.js:63
		throw new Error(
		      ^

Error: Cannot find module @rollup/rollup-linux-x64-musl. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
    at requireWithFriendlyError (/admin-interface/node_modules/rollup/dist/native.js:63:9)
    at Object.<anonymous> (/admin-interface/node_modules/rollup/dist/native.js:72:76)
    ... 3 lines matching cause stack trace ...
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at cjsLoader (node:internal/modules/esm/translators:346:17)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:286:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24) {
  [cause]: Error: Cannot find module '@rollup/rollup-linux-x64-musl'
  Require stack:
  - /admin-interface/node_modules/rollup/dist/native.js
      at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
      at Module._load (node:internal/modules/cjs/loader:1051:27)
      at Module.require (node:internal/modules/cjs/loader:1311:19)
      at require (node:internal/modules/helpers:179:18)
      at requireWithFriendlyError (/admin-interface/node_modules/rollup/dist/native.js:45:10)
      at Object.<anonymous> (/admin-interface/node_modules/rollup/dist/native.js:72:76)
      at Module._compile (node:internal/modules/cjs/loader:1469:14)
      at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
      at Module.load (node:internal/modules/cjs/loader:1288:32)
      at Module._load (node:internal/modules/cjs/loader:1104:12) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [ '/admin-interface/node_modules/rollup/dist/native.js' ]
  }
}

Node.js v20.18.1

github-actions · 2025-01-03T15:35:34Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2025-01-15T10:57:33Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2025-01-29T14:20:35Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2025-01-29T14:20:35Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2025-02-11T09:08:06Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

JulianKniephoff · 2025-02-20T14:56:46Z

@majosch that's an unrelated problem between npm and our dependencies that we should investigate and fix, but not something we can do anything about as part of this PR, can you maybe try building the project from source?

The container (at least the way you try to start it) is not going to be of much help anyway, since it's going to talk to develop.opencast.org, which doesn't have the life cycle management backend code, yet.

github-actions · 2025-02-26T13:56:22Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2025-02-27T08:43:50Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2025-03-03T16:27:21Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

github-actions · 2025-03-12T22:52:23Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Arnei added the type:enhancement New feature or request label Dec 4, 2024

github-actions bot added the status:conflicts label Dec 4, 2024

Arnei added 2 commits December 4, 2024 11:24

Fix typescript complaint

5e5a850

Type LifeCyclePolicy was missing on a union type.

Arnei force-pushed the lifecycle-write branch from e7b3c5f to 6d9e5a4 Compare December 4, 2024 10:27

github-actions bot removed the status:conflicts label Dec 4, 2024

Add Create, Edit, Delete for LifeCycle Policies

c2d1c40

Instead of only being able to view lifecycle policies, this commit lets you edit them, create new ones and even delete them. Depends on changes to the backend.

Arnei force-pushed the lifecycle-write branch from 6d9e5a4 to c2d1c40 Compare December 4, 2024 11:01

github-actions bot added the status:conflicts label Dec 11, 2024

Merge branch 'main' into lifecycle-write

2dd5a74

github-actions bot added status:conflicts and removed status:conflicts labels Dec 11, 2024

Merge branch 'main' into lifecycle-write

aae8eda

github-actions bot removed the status:conflicts label Dec 12, 2024

github-actions bot added the status:conflicts label Jan 3, 2025

Merge branch 'main' into lifecycle-write

d6ae3d8

github-actions bot removed the status:conflicts label Jan 3, 2025

github-actions bot added status:conflicts and removed status:conflicts labels Jan 15, 2025

Merge branch 'main' into lifecycle-write

9fff939

Arnei force-pushed the lifecycle-write branch from de284b1 to 9fff939 Compare January 15, 2025 15:10

Merge branch 'main' into lifecycle-write

f40dc0f

github-actions bot removed the status:conflicts label Jan 17, 2025

github-actions bot added the status:conflicts label Jan 29, 2025

Merge branch 'main' into lifecycle-write

9caae0f

github-actions bot removed the status:conflicts label Jan 31, 2025

Fix modal usage errors

865e34c

github-actions bot added the status:conflicts label Feb 11, 2025

github-actions bot removed the status:conflicts label Feb 11, 2025

Merge branch 'main' into lifecycle-write

691ffac

Arnei force-pushed the lifecycle-write branch from fa5ccf3 to 691ffac Compare February 11, 2025 09:42

github-actions bot added the status:conflicts label Feb 26, 2025

Merge branch 'main' into lifecycle-write

cd4becf

github-actions bot added status:conflicts and removed status:conflicts labels Feb 26, 2025

Merge branch 'main' into lifecycle-write

e876307

github-actions bot added status:conflicts and removed status:conflicts labels Feb 27, 2025

Merge branch 'main' into lifecycle-write

5e15fb4

github-actions bot added status:conflicts and removed status:conflicts labels Mar 10, 2025

Merge branch 'main' into lifecycle-write

05854ff

github-actions bot removed the status:conflicts label Mar 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Create, Edit, Delete for LifeCycle Policies #1004

Add Create, Edit, Delete for LifeCycle Policies #1004

Arnei commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 12, 2024

LukasKalbertodt commented Dec 17, 2024

majosch commented Dec 18, 2024

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 29, 2025

github-actions bot commented Jan 29, 2025

github-actions bot commented Feb 11, 2025

JulianKniephoff commented Feb 20, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 27, 2025

github-actions bot commented Mar 3, 2025

github-actions bot commented Mar 12, 2025

Add Create, Edit, Delete for LifeCycle Policies #1004

Are you sure you want to change the base?

Add Create, Edit, Delete for LifeCycle Policies #1004

Conversation

Arnei commented Dec 4, 2024 • edited Loading

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024 • edited Loading

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 12, 2024

LukasKalbertodt commented Dec 17, 2024

majosch commented Dec 18, 2024

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 29, 2025

github-actions bot commented Jan 29, 2025

github-actions bot commented Feb 11, 2025

JulianKniephoff commented Feb 20, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 27, 2025

github-actions bot commented Mar 3, 2025

github-actions bot commented Mar 12, 2025

Arnei commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading