Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to @opencast/eslint-config-ts-react #1118

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Feb 24, 2025

Fixes #713.

Thanks to @ LukasKalbertodt , our Opencast eslint config for typescript-react is now compatible with eslint 9.
High time to not only update to eslint 9, but also to replace our old eslint config with @opencast/eslint-config-ts-react. The old config was a default config provided by CreateReactApp, which is not maintained anymore and we have no other reason to keep it around.

That said, this patch only aims to update dependencies and introduce @opencast/eslint-config-ts-react. It does not aim to fulfill the numerous rules the project is now breaking, which is why most of those rules are disabled. They can be gradually enabeled by future patches, when they won't cause massive merge conflicts for the larger outstanding pull requests like #1006 or #1059.

Update: Enabled rules which we were mostly following everywhere already and which required only changing a few lines.

How to test this

Check out the code, break some rules and see eslint complaining about it during build (or in your IDE if so configured).

Thanks to @ LukasKalbertodt , our Opencast eslint config for
typescript-react is now compatible with eslint 9.
High time to not only update to eslint 9, but also to replace our old
eslint config with @opencast/eslint-config-ts-react.
The  old config was a default  config provided by CreateReactApp,
which is not maintained anymore and we have no other reason to keep
it around.

That said, this patch only aims to update dependencies and introduce
@opencast/eslint-config-ts-react. It does not aim to fulfill the
numerous rules the project is now breaking, which is why most of those
rules are disabled. They can be gradually enabeled by future patches.
@Arnei Arnei added type:dependencies Pull requests that update a dependency file type:infrastructure Build process, deployment, workflows labels Feb 24, 2025
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1118

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1118

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Feb 24, 2025

This pull request is deployed at test.admin-interface.opencast.org/1118/2025-03-20_15-00-48/ .
It might take a few minutes for it to become available.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:dependencies Pull requests that update a dependency file type:infrastructure Build process, deployment, workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change ESLint configuration
1 participant