-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to @opencast/eslint-config-ts-react #1118
base: main
Are you sure you want to change the base?
Conversation
Thanks to @ LukasKalbertodt , our Opencast eslint config for typescript-react is now compatible with eslint 9. High time to not only update to eslint 9, but also to replace our old eslint config with @opencast/eslint-config-ts-react. The old config was a default config provided by CreateReactApp, which is not maintained anymore and we have no other reason to keep it around. That said, this patch only aims to update dependencies and introduce @opencast/eslint-config-ts-react. It does not aim to fulfill the numerous rules the project is now breaking, which is why most of those rules are disabled. They can be gradually enabeled by future patches.
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
This pull request is deployed at test.admin-interface.opencast.org/1118/2025-03-20_15-00-48/ . |
This pull request has conflicts ☹ |
This pull request has conflicts ☹ |
This pull request has conflicts ☹ |
This pull request has conflicts ☹ |
This pull request has conflicts ☹ |
This pull request has conflicts ☹ |
This pull request has conflicts ☹ |
Fixes #713.
Thanks to @ LukasKalbertodt , our Opencast eslint config for typescript-react is now compatible with eslint 9.
High time to not only update to eslint 9, but also to replace our old eslint config with @opencast/eslint-config-ts-react. The old config was a default config provided by CreateReactApp, which is not maintained anymore and we have no other reason to keep it around.
That said, this patch only aims to update dependencies and introduce @opencast/eslint-config-ts-react. It does not aim to fulfill the numerous rules the project is now breaking, which is why most of those rules are disabled. They can be gradually enabeled by future patches, when they won't cause massive merge conflicts for the larger outstanding pull requests like #1006 or #1059.
Update: Enabled rules which we were mostly following everywhere already and which required only changing a few lines.
How to test this
Check out the code, break some rules and see eslint complaining about it during build (or in your IDE if so configured).