Replace custom OAuth auth module with built-in OIDC provider #133
+156
−549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thunder IDP now supports standard OIDC with well-known discovery endpoints, refresh tokens, and standard claims. This replaces the custom OAuth implementation with Backstage's built-in oidcAuthenticator. Changes: - Rename plugin: auth-backend-module-openchoreo-default → openchoreo-idp - Simplify auth module from ~380 lines to ~90 lines using oidcAuthenticator - Remove custom JWT utilities (jwtUtils.ts) - OIDC handles token validation - Remove pseudo-refresh token workaround - Thunder now returns real refresh tokens - Rename provider ID: default-idp → openchoreo-idp for clarity - Update config to use metadataUrl (OIDC discovery) instead of manual URLs - Add session.secret requirement for OIDC cookie-based sessions Breaking changes: - Provider ID changed from 'default-idp' to 'openchoreo-idp' - Config structure changed: authorizationUrl/tokenUrl → metadataUrl - Thunder callback URL must be updated to /api/auth/openchoreo-idp/handler/frame - SESSION_SECRET env var now required Fixes: openchoreo/openchoreo#1198
kaviththiranga
requested review from
jhivandb and
sameerajayasoma
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thunder IDP now supports standard OIDC with well-known discovery endpoints,
refresh tokens, and standard claims. This replaces the custom OAuth
implementation with Backstage's built-in oidcAuthenticator.
Changes:
Breaking changes:
Fixes: openchoreo/openchoreo#1198