ocd for 'November 2019 Spanish general election' and existing parliament #173
Conversation
| @@ -0,0 +1,2 @@ | |||
| ocd-division/country:es/autonomous_region:ce,Ceuta | |||
| ocd-division/country:es/autonomous_region:ml,Melilla | |||
There was a problem hiding this comment.
I'd lean towards "region" here instead of "autonomous_region" but I won't block on that.
There was a problem hiding this comment.
i used "autonomous_region" because of the portugal PR.
Where we have a difference between i.e Lisboa and Acores
ocd-division/country:pt/region:li - Lisboa
ocd-division/country:pt/autonomous_region:ac - Acores
Lisboa is a region in Portugal, but Acores is a autonomous region (no normal region).
So I'd suggest to use "autonomous_region" in this special cases.
There was a problem hiding this comment.
I see Ceuta and Melilla listed as autonomous cities on the Wikipedia page about autonomous communities, which suggests to me that they are autonomous communities like the other 'states'. Shouldn't they then all have the same OCD type?
I got confused because your comment is about Portugal, but this PR is about Spain.
There was a problem hiding this comment.
I changes both now to "autonomous_city".
Sorry for confusion. I used portugal as an example for spain, because of the similar problem.
Ceute and Melilla have in spain an other "political status". So my suggestion would be to have a difference to the other communities, but if you both say "we should use the same ocd type", I can change that again.
@jpmckinney @jdmgoogle
There was a problem hiding this comment.
I don't know the details for Portugal, so I defer to you, @sguenther85.
multi-line issue
removed last line
|
@jdmgoogle @jpmckinney @jpmckinney any question or opinions about @jdmgoogle and my questions above? The elections are not far way. Would like to move forward and find a good solution ;) |
| @@ -0,0 +1,2 @@ | |||
| ocd-division/country:es/autonomous_region:ce,Ceuta | |||
| ocd-division/country:es/autonomous_region:ml,Melilla | |||
| @@ -0,0 +1,2 @@ | |||
| ocd-division/country:es/autonomous_region:ce,Ceuta | |||
| ocd-division/country:es/autonomous_region:ml,Melilla | |||
There was a problem hiding this comment.
I see Ceuta and Melilla listed as autonomous cities on the Wikipedia page about autonomous communities, which suggests to me that they are autonomous communities like the other 'states'. Shouldn't they then all have the same OCD type?
I got confused because your comment is about Portugal, but this PR is about Spain.
Pronvices with iso code sorted
autonomous_community with iso codes
autonomous_region to autonomous_city
No description provided.