Skip to content

Revert: display total skills count (fixes #357)#359

Merged
steipete merged 1 commit intomainfrom
fix/revert-count-public-skills
Feb 16, 2026
Merged

Revert: display total skills count (fixes #357)#359
steipete merged 1 commit intomainfrom
fix/revert-count-public-skills

Conversation

@steipete
Copy link
Collaborator

@steipete steipete commented Feb 16, 2026

Reverts commit 8993395 which broke the /skills page with a Convex server error on countPublicSkills.

The globalStats table/cron was added but likely hasn't been properly initialized in the Convex deployment, causing a server error when querying it.

Fixes #357

cc @rknoche6 — happy to help you re-land this properly once the schema migration is sorted.

Greptile Summary

Clean revert of commit 8993395 ("display total skills count on /skills page (#76)") to fix a Convex server error on the /skills page (#357). The original commit added a globalStats table, a countPublicSkills query, a cron job to update global stats, and UI to display the total count in the page header. Since the globalStats table was never properly initialized in the Convex deployment, the countPublicSkills query caused a server error.

  • Removes the globalStats table definition from convex/schema.ts
  • Removes the countPublicSkills query from convex/skills.ts
  • Removes the updateGlobalStatsInternal mutation and its hourly cron from convex/statsMaintenance.ts and convex/crons.ts
  • Reverts the /skills page UI to no longer display the total skills count
  • Cleans up test mocks for useQuery that were added for the feature
  • Removes the corresponding CHANGELOG entry

Verified this is a byte-for-byte clean revert — the resulting files are identical to the state before the original feature commit.

Confidence Score: 5/5

  • This PR is safe to merge — it is a clean, complete revert restoring the codebase to a known-good state.
  • The revert produces zero diff against the pre-feature commit (e352309), confirming it is an exact rollback. The feature being reverted was merged but broken in production due to an uninitialized table. No new code is introduced, no partial changes remain, and tests are updated to match.
  • No files require special attention.

Last reviewed commit: 87dd677

Context used:

  • Context from dashboard - AGENTS.md (source)

@vercel
Copy link
Contributor

vercel bot commented Feb 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clawhub Ready Ready Preview, Comment Feb 16, 2026 4:46pm

@cursor
Copy link

cursor bot commented Feb 16, 2026

PR Summary

Low Risk
This is a revert that removes a failing read path and related maintenance code; it should reduce runtime errors, with minimal functional impact beyond hiding the total count.

Overview
Removes the /skills header total-count display by dropping the countPublicSkills Convex query and its corresponding useQuery call in the skills index route.

Reverts the uninitialized global stats infrastructure by deleting the globalStats table from the Convex schema, removing the hourly global-stats-update cron, and eliminating the updateGlobalStatsInternal maintenance mutation. Tests are updated to stop mocking useQuery for this page.

Written by Cursor Bugbot for commit 87dd677. This will update automatically on new commits. Configure here.

@steipete steipete merged commit 38c4a67 into main Feb 16, 2026
6 checks passed
@rknoche6
Copy link
Contributor

Thanks a lot @steipete !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Last pr (mine) broke the skills list

2 participants