Fix initial skill sorting

convex/skills.ts

@@ -720,23 +720,43 @@ export const listPublicPage = query({
 export const listPublicPageV2 = query({
   args: {
     paginationOpts: paginationOptsValidator,
+    sort: v.optional(
+      v.union(
+        v.literal('newest'),
+        v.literal('updated'),
+        v.literal('downloads'),
+        v.literal('installs'),
+        v.literal('stars'),
+        v.literal('name'),
+      ),
+    ),
+    dir: v.optional(v.union(v.literal('asc'), v.literal('desc'))),
   },
   handler: async (ctx, args) => {
-    // Use the new index to filter out soft-deleted skills at query time.
-    // softDeletedAt === undefined means active (non-deleted) skills only.
+    const sort = args.sort ?? 'updated'
+    const dir = args.dir ?? 'desc'
+
+    const indexName =
+      sort === 'downloads'
+        ? 'by_stats_downloads'
+        : sort === 'stars'
+          ? 'by_stats_stars'
+          : sort === 'installs'
+            ? 'by_stats_installs_all_time'
+            : 'by_active_updated'
+
+    const useActiveFilter = indexName === 'by_active_updated'
+
     const result = await paginator(ctx.db, schema)
       .query('skills')
-      .withIndex('by_active_updated', (q) => q.eq('softDeletedAt', undefined))
-      .order('desc')
+      .withIndex(indexName, useActiveFilter ? (q) => q.eq('softDeletedAt', undefined) : (q) => q)
+      .order(dir)
       .paginate(args.paginationOpts)
 
-    // Build the public skill entries (fetch latestVersion + ownerHandle)
-    const items = await buildPublicSkillEntries(ctx, result.page)
+    const page = useActiveFilter ? result.page : result.page.filter((s) => !s.softDeletedAt)
+    const items = await buildPublicSkillEntries(ctx, page)
 
-    return {
-      ...result,
-      page: items,
-    }
+    return { ...result, page: items }
   },
 })
 

src/__tests__/skills-index.test.tsx

@@ -48,10 +48,10 @@ describe('SkillsIndex', () => {
 
   it('requests the first skills page', () => {
     render(<SkillsIndex />)
-    // usePaginatedQuery should be called with the API endpoint and empty args
+    // usePaginatedQuery should be called with the API endpoint and sort/dir args
     expect(usePaginatedQueryMock).toHaveBeenCalledWith(
       expect.anything(),
-      {},
+      { sort: 'newest', dir: 'desc' },
       { initialNumItems: 25 },
     )
   })

src/routes/skills/index.tsx

@@ -84,7 +84,7 @@ export function SkillsIndex() {
     results: paginatedResults,
     status: paginationStatus,
     loadMore: loadMorePaginated,
-  } = usePaginatedQuery(api.skills.listPublicPageV2, hasQuery ? 'skip' : {}, {
+  } = usePaginatedQuery(api.skills.listPublicPageV2, hasQuery ? 'skip' : { sort, dir }, {
     initialNumItems: pageSize,
   })