Skip to content

fix: refresh embedded web assets#32

Merged
vincentkoc merged 2 commits into
mainfrom
fix/ci-generated-assets
Jun 25, 2026
Merged

fix: refresh embedded web assets#32
vincentkoc merged 2 commits into
mainfrom
fix/ci-generated-assets

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The latest CI on main failed because the checked-in embedded web assets no longer matched the generated Svelte bundle.

Why This Change Was Made

Regenerated the embedded web distribution with the repository build so the committed hashed assets match the current source output.

User Impact

Restores green CI and keeps the API binary embedding the current web UI assets.

Evidence

  • pnpm install --frozen-lockfile
  • pnpm build
  • pnpm test && pnpm typecheck && pnpm -r typecheck && pnpm lint && pnpm fmt:check

@clawsweeper

clawsweeper Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed June 25, 2026, 2:54 AM ET / 06:54 UTC.

Summary
The PR refreshes checked-in generated web assets under apps/api/internal/webassets/dist so SvelteKit HTML, entry, chunk, and node references point to regenerated bundle filenames.

Reproducibility: not applicable. as a runtime bug reproduction path; this is a generated asset refresh. Source inspection confirms the API embeds the checked-in dist tree and the build script regenerates that tree, but I did not run the build in this read-only review.

Review metrics: 1 noteworthy metric.

  • Generated asset surface: 10 files changed, 78 additions, 78 deletions. The diff is confined to checked-in built web assets, so review should focus on bundle coherence and CI output rather than hand-authored application logic.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P2] Wait for Playwright E2E to complete before merge.

Risk before merge

  • [P1] Playwright E2E was still in progress at review time, so maintainers should wait for the required checks to finish before merging.
  • [P1] I did not rerun the build or test commands locally because this review is read-only and those commands can write build or cache artifacts.

Maintainer options:

  1. Decide the mitigation before merge
    Merge the generated asset refresh after CI confirms the committed dist tree matches the current Svelte build output.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • [P2] No repair-lane action is needed because this PR already contains the focused generated-asset refresh and only needs normal CI-backed maintainer review.

Security
Cleared: The diff is limited to generated static web assets and HTML references, with no dependency, workflow, secret, installer, or permission changes.

Review details

Best possible solution:

Merge the generated asset refresh after CI confirms the committed dist tree matches the current Svelte build output.

Do we have a high-confidence way to reproduce the issue?

Not applicable as a runtime bug reproduction path; this is a generated asset refresh. Source inspection confirms the API embeds the checked-in dist tree and the build script regenerates that tree, but I did not run the build in this read-only review.

Is this the best way to solve the issue?

Yes. Regenerating the embedded SvelteKit bundle is the narrow maintainable fix for a mismatch between source output and checked-in web assets.

AGENTS.md: found, but no applicable review policy affected this item.

Codex review notes: model internal, reasoning high; reviewed against 9d29bc6356f2.

Label changes

Label changes:

  • add P3: This is a low-risk generated-asset refresh for CI and embedded web UI consistency, with no reported production outage or data impact.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The PR author is a repository member, so the external-contributor real behavior proof gate does not apply; the PR body still lists build and validation commands.

Label justifications:

  • P3: This is a low-risk generated-asset refresh for CI and embedded web UI consistency, with no reported production outage or data impact.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The PR author is a repository member, so the external-contributor real behavior proof gate does not apply; the PR body still lists build and validation commands.
Evidence reviewed

What I checked:

Likely related people:

  • vincentkoc: Current main history includes recent client runtime and web-dist test handling work by vincentkoc, and earlier generated asset history also includes their commits, so they are a strong routing candidate beyond only authoring this PR. (role: recent area contributor; confidence: high; commits: 9d29bc6356f2, 3848eddb6017, 95b912877156; files: scripts/go-test-with-web-dist.mjs, apps/api/internal/webassets/dist/index.html, apps/api/internal/webassets/dist/_app/immutable/entry/app.Sw08gAEk.js)
  • steipete: Peter Steinberger introduced the root build/embed scripts and the Go embedded asset package, and has multiple historical refreshes in the embedded web asset tree. (role: introduced behavior; confidence: high; commits: e0de6adf9cf0, 758fdce94971, 644bba191740; files: package.json, scripts/embed-web-dist.mjs, apps/api/internal/webassets/webassets.go)
  • PollyBot13: The current main old hashed asset names were introduced in a recent merged web feature commit that regenerated this same embedded asset tree. (role: recent generated asset contributor; confidence: medium; commits: 4f71257cbc61; files: apps/api/internal/webassets/dist/index.html, apps/api/internal/webassets/dist/_app/immutable/chunks/Vg7HUXRy.js)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. labels Jun 25, 2026
@vincentkoc
vincentkoc merged commit 22e635b into main Jun 25, 2026
4 checks passed
@vincentkoc
vincentkoc deleted the fix/ci-generated-assets branch June 25, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant