feat: add Hermes Agent connector example#78
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 16, 2026, 10:12 AM ET / 14:12 UTC. Summary Reproducibility: not applicable. This PR adds a new Hermes integration and supporting capabilities rather than repairing a defined broken behavior. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Either keep the Hermes bridge external and land only independently justified generic API and SDK improvements, or explicitly adopt it as a first-party example with exact-head live proof and named ownership for security, delivery, CI, and upstream compatibility. Do we have a high-confidence way to reproduce the issue? Not applicable; this PR adds a new Hermes integration and supporting capabilities rather than repairing a defined broken behavior. Is this the best way to solve the issue? Unclear pending product direction: the implementation is credible, but an external connector plus narrowly separated generic API and SDK additions is the lower-maintenance solution unless maintainers explicitly want first-party Hermes ownership. AGENTS.md: found, but no applicable review policy affected this item. Codex review notes: model internal, reasoning high; reviewed against 346c80c14413. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
|
Addressed the two review blockers:
Focused regression coverage includes unauthorized users/channels, malformed targets, cursor-store recovery, out-of-order completion, failed persistence, shutdown aborts, and exhausted delivery retries. Verification against PR head
Crabbox note: its Blaxel lifecycle adapter was locally provenance-patched to use the provider's current Please re-review when convenient. |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: feat: add Hermes Agent connector example This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
|
Sweet! Please live test this and provide screenshots! |
|
I wonder tho - shouldn't that connector be in Hermes, and not clickclack? Just like we have a clickclack connector in OpenClaw? |
|
Thank you for putting so much care into this, especially the authorization, cursor recovery, and live validation work. We have decided not to maintain the Hermes connector inside ClickClack. The bridge fits better on the Hermes side, or in its own repository, where its ownership, compatibility work, and release cadence can follow Hermes directly. The generic capabilities this surfaced are valuable. We will bring the reusable realtime pagination, bounded thread-history behavior, and agent-progress SDK support into ClickClack's API and SDK, with credit to you in the changelog. We would be glad to see the Hermes connector build against those framework-neutral capabilities from its natural home. Thanks again for the thoughtful contribution and for helping sharpen the integration boundary. |
|
Thanks so much, Pete. We really appreciate the kind words, the clear boundary, and the way you carried the generic pieces forward. Seeing the history helpers and typed agent-progress SDK land in #91 and #92 with Cad’s co-author credit and We’ll explore moving the Hermes-specific connector to the Hermes side as a standalone platform plugin. Thanks again for taking the contribution seriously and getting the reusable parts into ClickClack 🙏 |
Summary
examples/hermes-agentusing Hermes' public Runs and SSE APIsagent.progressevents, DM pagination, and latest bounded thread windowsSafety and lifecycle
Testing
pnpm check