fix(cli): give runtimeForApp a timed HTTP client

internal/cli/provider_backend.go

@@ -1677,8 +1677,14 @@ func routeConfiguredProvider(cfg *Config) error {
 	return nil
 }
 
+const defaultRuntimeHTTPTimeout = 60 * time.Second
+
+func defaultRuntimeHTTP() *http.Client {
+	return &http.Client{Timeout: defaultRuntimeHTTPTimeout}
+}
+
 func runtimeForApp(a App) Runtime {
-	return Runtime{Stdout: a.Stdout, Stderr: a.Stderr, Clock: realClock{}, Exec: execCommandRunner{}}
+	return Runtime{Stdout: a.Stdout, Stderr: a.Stderr, Clock: realClock{}, HTTP: defaultRuntimeHTTP(), Exec: execCommandRunner{}}
 }
 
 const (

internal/cli/provider_exports.go

@@ -25,7 +25,7 @@ func RuntimeForProviderOperation(stderr io.Writer) Runtime {
 	if stderr == nil {
 		stderr = io.Discard
 	}
-	return Runtime{Stdout: io.Discard, Stderr: stderr, Clock: realClock{}, Exec: execCommandRunner{}}
+	return Runtime{Stdout: io.Discard, Stderr: stderr, Clock: realClock{}, HTTP: defaultRuntimeHTTP(), Exec: execCommandRunner{}}
 }
 
 // ProviderSelectionIsAuthoritativeRoute reports whether cfg names an exact

internal/cli/runtime_http_test.go

@@ -0,0 +1,27 @@
+package cli
+
+import (
+	"io"
+	"testing"
+	"time"
+)
+
+func TestRuntimeForAppSetsTimedHTTPClient(t *testing.T) {
+	rt := runtimeForApp(App{})
+	if rt.HTTP == nil {
+		t.Fatal("runtimeForApp HTTP is nil")
+	}
+	if got, want := rt.HTTP.Timeout, 60*time.Second; got != want {
+		t.Fatalf("runtimeForApp HTTP Timeout = %v, want %v", got, want)
+	}
+}
+
+func TestRuntimeForProviderOperationSetsTimedHTTPClient(t *testing.T) {
+	rt := RuntimeForProviderOperation(io.Discard)
+	if rt.HTTP == nil {
+		t.Fatal("RuntimeForProviderOperation HTTP is nil")
+	}
+	if got, want := rt.HTTP.Timeout, 60*time.Second; got != want {
+		t.Fatalf("RuntimeForProviderOperation HTTP Timeout = %v, want %v", got, want)
+	}
+}