feat(remote): add archive snapshot provenance#50
Conversation
|
Codex review: found issues before merge. Reviewed July 12, 2026, 6:01 AM ET / 10:01 UTC. Summary Reproducibility: not applicable. This PR adds a new remote snapshot lifecycle rather than fixing broken current-main behavior. The earlier source-visible legacy-key compatibility defect is fixed at the current head. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review findings
Review detailsBest possible solution: Preserve the additive APIs and legacy default layout, remove the feature-branch changelog entry, then record temporary-data downstream smoke output covering legacy bundle discovery plus snapshot publish, retry, pinned query, and cutover. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR adds a new remote snapshot lifecycle rather than fixing broken current-main behavior. The earlier source-visible legacy-key compatibility defect is fixed at the current head. Is this the best way to solve the issue? Yes, the separate opt-in snapshot builder and additive client fields are the narrowest maintainable approach because they retain the released legacy API and key layout. The remaining work is release-note cleanup and upgrade proof, not a competing implementation. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 17d1ba056e14. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (3 earlier review cycles)
|
Summary
Tests\n-
GOWORK=off go test ./... -count=1\n-GOWORK=off go test -race ./... -count=1\n-GOWORK=off go vet ./...\n- Windows amd64 cross-compile, tidy, formatting, andgit diff --check