feat: add safe hybrid local archive collection#139
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 18, 2026, 2:28 AM ET / 06:28 UTC. Summary Reproducibility: not applicable. This PR proposes a new hybrid collection mode rather than reporting broken existing behavior. The supplied validation describes automated checks and an isolated CLI smoke, but no bug reproduction is required for this classification. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Adopt a concise, maintainer-approved hybrid-archive contract that defines safe-update preservation, exclusion precedence, and Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes a new hybrid collection mode rather than reporting broken existing behavior. The supplied validation describes automated checks and an isolated CLI smoke, but no bug reproduction is required for this classification. Is this the best way to solve the issue? Unclear: the implementation is internally focused and has no discrete blocking code finding in the available review record, but whether native hybrid archive persistence is the right supported core contract requires maintainer direction. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against 15af97146636. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: feat: add safe hybrid local archive collection This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
|
Closing because Please send only independently reproduced, bounded bugs as separate focused PRs with targeted proof. |
Summary
Safety properties
Validation
go test ./...go test -race ./...go vet ./...golangci-lint,staticcheck,deadcode, andgosecdarwin/arm64static builds:37e13b24fb4f1c286da184c52554778243b3c2f600eb81d65e7c7b077bacf597vcs.revision=d7c07e25e60b7749c4a47de72349830099c52c1aandvcs.modified=falseQualified against upstream
1d1b8a0a61ac060fc3d72a30221f32672b8e31dc.