fix(oauth): preserve primary cache fallback#228
Merged
Conversation
Collaborator
Author
|
Land-ready proof for exact head
Risk: medium. The change touches OAuth persistence priority and recovery snapshots, with a focused unreadable-secondary-store regression covering tokens and client information. |
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokenCacheDirwhen the lower-priority shared OAuth vault is unreadableRoot cause
The rejected-refresh recovery landed in 85f4c9e changed composite token and client reads from ordered fallback to
Promise.all. A lower-priority vault read error could therefore invalidate a usable explicit cache.Proof
pnpm exec vitest run tests/oauth-persistence.test.ts tests/runtime-transport.test.ts— 73 passedpnpm check && pnpm test— formatting, lint, typecheck, and build clean; 833 passed, 3 skippeddcb683fb959a011dacf1ef80e04eb63289750bf9; deterministic rotating-token E2E and repository tests accepted for landingRelated: #226