Skip to content

fix(oauth): preserve primary cache fallback#228

Merged
steipete merged 1 commit into
mainfrom
fix/oauth-primary-cache-fallback
Jul 11, 2026
Merged

fix(oauth): preserve primary cache fallback#228
steipete merged 1 commit into
mainfrom
fix/oauth-primary-cache-fallback

Conversation

@steipete

Copy link
Copy Markdown
Collaborator

Summary

  • preserve the established priority of an explicit tokenCacheDir when the lower-priority shared OAuth vault is unreadable
  • retain successful secondary-store snapshots for generation-aware rejected-credential recovery
  • add regression coverage for both cached tokens and cached client information

Root cause

The rejected-refresh recovery landed in 85f4c9e changed composite token and client reads from ordered fallback to Promise.all. A lower-priority vault read error could therefore invalidate a usable explicit cache.

Proof

Related: #226

@steipete

Copy link
Copy Markdown
Collaborator Author

Land-ready proof for exact head dcb683fb959a011dacf1ef80e04eb63289750bf9:

Risk: medium. The change touches OAuth persistence priority and recovery snapshots, with a focused unreadable-secondary-store regression covering tokens and client information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant