docs: correct call timeout guidance#232
Conversation
Co-authored-by: KrasimirKralev <krasi@idrobots.com>
|
Codex review: found issues before merge. Reviewed July 18, 2026, 3:34 PM ET / 19:34 UTC. Summary Reproducibility: not applicable. This PR corrects documentation rather than a runtime defect. The relevant contract is directly verifiable from the current timeout-resolution and call-command source paths. Review metrics: 1 noteworthy metric.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the two source-accurate documentation corrections without modifying Do we have a high-confidence way to reproduce the issue? Not applicable: this PR corrects documentation rather than a runtime defect. The relevant contract is directly verifiable from the current timeout-resolution and call-command source paths. Is this the best way to solve the issue? Yes, after removing the release-owned changelog entry. Updating the two user-facing documentation surfaces to match the existing 30-second list and 60-second call defaults is the narrowest maintainable fix. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 710840fb7dd0. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
MCPORTER_CALL_TIMEOUTand--timeout@KrasimirKralevContributor credit
Maintainer-owned replacement for #230 because its fork does not permit maintainer edits. This commit preserves the original PR commit author's exact credit with:
Co-authored-by: KrasimirKralev <krasi@idrobots.com>Supersedes #230. Leave #230 open until this replacement lands and the maintainer closes the original PR.
Proof
mcporter call --helpexposes--timeout <ms>