Skip to content

fix(dev-install): detect OpenClaw CLI entrypoint dynamically #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alauppe merged 2 commits into from
Mar 11, 2026
Merged

fix(dev-install): detect OpenClaw CLI entrypoint dynamically #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6e22e
fix(dev-install): resolve OpenClaw CLI entrypoint path dynamically
ninjaa Mar 5, 2026
4cc27b4
fix(dev-install): resolve CLI entrypoint from metadata with fallbacks
alauppe Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 76 additions & 3 deletions roles/openclaw/tasks/openclaw-development.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,87 @@
msg: "Build failed - dist directory not found"
when: not dist_dir.stat.exists

- name: Check for package metadata
ansible.builtin.stat:
path: "{{ openclaw_repo_dir }}/package.json"
register: openclaw_package_json_stat

- name: Read package metadata
ansible.builtin.slurp:
src: "{{ openclaw_repo_dir }}/package.json"
register: openclaw_package_json_raw
when: openclaw_package_json_stat.stat.exists

- name: Parse package metadata
ansible.builtin.set_fact:
openclaw_package_json: "{{ openclaw_package_json_raw.content | b64decode | from_json }}"
when: openclaw_package_json_stat.stat.exists

- name: Resolve metadata-defined CLI entrypoint
ansible.builtin.set_fact:
openclaw_package_bin_entry: >-
{{
openclaw_package_json.bin
if openclaw_package_json.bin is string else
(
openclaw_package_json.bin.openclaw
if openclaw_package_json.bin is mapping and 'openclaw' in openclaw_package_json.bin else
Comment on lines +106 to +110
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Guard missing package.json bin before dereferencing

This expression dereferences openclaw_package_json.bin repeatedly without an is defined/default guard, so if package.json exists but has no bin key (or sets bin: null), the task can fail during templating before fallback probes run. In that case the intended fallback paths (openclaw.mjs, bin/openclaw.js, dist/index.js) are never evaluated even if one exists, causing avoidable install failures.

Useful? React with 👍 / 👎.

(
(openclaw_package_json.bin | dict2items | map(attribute='value') | list | first)
if openclaw_package_json.bin is mapping else
''
)
)
}}
when: openclaw_package_json_stat.stat.exists

- name: Build CLI entrypoint candidate list
ansible.builtin.set_fact:
openclaw_cli_candidate_paths: >-
{{
[
openclaw_package_bin_entry | default(''),
'openclaw.mjs',
'bin/openclaw.js',
'dist/index.js'
] | reject('equalto', '') | unique | list
}}

- name: Check possible OpenClaw CLI entrypoints
ansible.builtin.stat:
path: "{{ openclaw_repo_dir }}/{{ item }}"
loop: "{{ openclaw_cli_candidate_paths }}"
register: openclaw_cli_candidates

- name: Resolve OpenClaw CLI entrypoint path
ansible.builtin.set_fact:
openclaw_cli_entry: >-
{{
(
openclaw_cli_candidates.results
| selectattr('stat.exists')
| map(attribute='stat.path')
| list
| first
) | default('')
}}
changed_when: false

- name: Fail if openclaw CLI entrypoint is missing
ansible.builtin.fail:
msg: >-
Unable to locate OpenClaw CLI entrypoint in {{ openclaw_repo_dir }}.
Expected one of: {{ openclaw_cli_candidate_paths | join(', ') }}
when: openclaw_cli_entry == ""

- name: Remove existing global openclaw symlink (if any)
ansible.builtin.file:
path: "{{ openclaw_home }}/.local/bin/openclaw"
state: absent

- name: Create symlink to openclaw binary
ansible.builtin.file:
src: "{{ openclaw_repo_dir }}/bin/openclaw.js"
src: "{{ openclaw_cli_entry }}"
dest: "{{ openclaw_home }}/.local/bin/openclaw"
state: link
owner: "{{ openclaw_user }}"
Expand All @@ -99,7 +172,7 @@

- name: Make openclaw binary executable
ansible.builtin.file:
path: "{{ openclaw_repo_dir }}/bin/openclaw.js"
path: "{{ openclaw_cli_entry }}"
mode: '0755'
owner: "{{ openclaw_user }}"
group: "{{ openclaw_user }}"
Expand All @@ -122,7 +195,7 @@
msg: |
OpenClaw installed from source: {{ openclaw_dev_version.stdout }}
Repository: {{ openclaw_repo_dir }}
Binary: {{ openclaw_home }}/.local/bin/openclaw -> {{ openclaw_repo_dir }}/bin/openclaw.js
Binary: {{ openclaw_home }}/.local/bin/openclaw -> {{ openclaw_cli_entry }}

- name: Add development mode info to .bashrc
ansible.builtin.blockinfile:
Expand Down