Skip to content

fix(setup): validate current OpenClaw package lifecycle#999

Open
TheAngryPit wants to merge 19 commits into
openclaw:mainfrom
TheAngryPit:codex/native-new-session-companion
Open

fix(setup): validate current OpenClaw package lifecycle#999
TheAngryPit wants to merge 19 commits into
openclaw:mainfrom
TheAngryPit:codex/native-new-session-companion

Conversation

@TheAngryPit

@TheAngryPit TheAngryPit commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Problem: Windows Companion setup must install the exact OpenClaw package declared by its composed-candidate proof. Previously the expected digest stopped at CI provenance, so a changed HTTP response could reach npm without being tied to the reviewed artifact.
  • Impact: A substituted or corrupted composed package could be consumed after CI selected the intended URL.
  • Changed behavior: CI composes one package from immutable OpenClaw inputs, records its SHA-256, carries that digest through the Setup Engine contract, and verifies the downloaded HTTP response before the official installer/npm consumes the same local .tgz.
  • User impact: The embedded official LKG is 2026.7.1, now treated as the minimum security floor. It may advance only to a strictly newer official stable release. The current composed candidate remains separate: OpenClaw 2026.7.2 from frozen main plus the current #110382 fix. Digest mismatch fails closed before installation.
  • Non-goals: This PR does not ship the composed package as an official release, change OpenClaw Core ownership, alter LKG rollback semantics, add permissions, or modify tokens, secrets, models, memory, plugins, or command authority.

Change Type

  • Bug fix
  • Feature
  • Refactor
  • Docs or instructions
  • Tests or validation
  • Security hardening
  • Chore or infrastructure

Scope

  • Tray or WinUI UX
  • Windows node capability
  • Local MCP or winnode
  • Gateway, connection, or pairing
  • Setup or onboarding
  • Permissions, privacy, or security
  • Tests, CI, or docs

Linked work

Frozen composition and artifact

Exact-head CI run: 30180239886

  • OpenClaw main: 6277c35d9a97cb128d32ed7ab5632cfc4163c746
  • Included upstream #111956 merge: 2296e898e13a5b250bf557e9632e000c093e61f1
  • #110382 patch base: 6277c35d9a97cb128d32ed7ab5632cfc4163c746
  • #110382 patch head: 6edc1e40f37b833ec0493ec331eba6cd49db4fb6
  • #110382 patch SHA-256: b1a5b0890db2268c33b8facd8396abed69fa5a0de92df0708f1dbd6eb5e97eab
  • Artifact: openclaw-2026.7.2-main-pr110382.tgz
  • Package SHA-256: 4fa6df8a8efdb46bbc93d509552ccd3d7dee962519ad9f3f2e816a6fe3c33e80
  • Package size: 33,567,130 bytes
  • Internal package version: 2026.7.2

The uploaded artifact contains provenance.json, SHA256SUMS, and the package. CI checks the source SHA, patch base and head, patch hash, changed-path allowlist, internal package version, and final package digest before any composed E2E consumer runs.

Exact-head validation

Published PR head: f5958e2190e5484a40ce551783765c0637a1786a

Fresh GitHub checks on this exact head are running. Repository hygiene and the advanced setup gate have passed; the composed-package and complete test jobs remain in progress.

The parent head 1f785aa399abef33b7ed422b394cc1bfb5128310 passed:

  • repository hygiene: passed
  • complete test job: passed
  • composed package build and provenance: passed
  • embedded LKG setup and connection: passed
  • composed setup and connection: passed
  • composed revocation recovery: passed
  • composed network recovery: passed
  • Windows x64 build: passed
  • Windows ARM64 build: passed
  • CodeQL setup gate: passed
  • release and MSIX jobs: skipped by normal PR conditions

The optional 2026.7.2-beta.3 compatibility canary reached a healthy restarted Gateway (HTTP 200) but lost the wizard connection before receiving the response. This lane is marked continue_on_error: true; it is not the embedded LKG or composed candidate and does not replace either supported contract.

Real behavior proof

The exact-head composed E2E used the artifact described above and passed the complete setup-and-connect scenario on a disposable GitHub Windows/WSL target.

The package-integrity boundary also has failed-first disposable proof:

  1. The Setup Engine downloaded the actual HTTP response.
  2. SHA-256 verification accepted the correct digest and passed that same local .tgz to the official installer/npm path.
  3. The installed CLI reported the expected OpenClaw version.
  4. With an intentionally wrong expected digest, verification failed before npm.
  5. The OpenClaw CLI remained absent after the failed attempt.

No operator runtime, private data, credentials, or channels were used.

Package and lifecycle compatibility

The embedded LKG, composed candidate, and historical beta canary have different jobs:

  • 2026.7.1 is the embedded official LKG fallback and minimum security floor.
  • 2026.7.2 composed from frozen main plus #110382 is the current reviewed candidate.
  • 2026.7.2-beta.3 is a non-blocking historical compatibility canary. It is not a production default.

The fallback policy is recorded in docs/adr/0001-gateway-lkg-security-floor.md. Automation accepts only exact official stable versions strictly newer than the current pin; it rejects prereleases, equal versions, and downgrades. Composed packages remain governed by their separate immutable version, URI, and digest contract.

Current and composed packages use gateway.nodes.commands.allow. The pinned historical packages retain their version-appropriate legacy command-policy key. All paths preserve the complete capability-derived allowlist.

Selected-port ownership is proven by matching every listener PID from ss to the managed openclaw-gateway.service MainPID. Unknown, mixed, or unattributable ownership fails closed. The patch does not kill processes or broaden command authority.

Security impact

  • New permissions or capabilities: No.
  • Secret or token handling changes: No.
  • New production network destination: No.
  • Broader command authority: No.
  • Integrity change: composed-package HTTP responses are bound to the reviewed SHA-256 and rejected before installation on mismatch.
  • Security-floor change: the ordinary fallback cannot regress below 2026.7.1 and cannot be replaced by a prerelease or composed package reference.

Compatibility and migration

  • Backward compatible: Yes.
  • Config migration: None.
  • Embedded official LKG: 2026.7.1.
  • Current composed candidate: frozen OpenClaw 2026.7.2 package described above.
  • Existing custom package URLs without an expected digest remain invalid for the governed composed-candidate path.
  • LKG automation now moves forward only to a strictly newer official stable release; rollback to an older fallback is intentionally rejected.

Review conversations

  • Reconciled the PR body with the workflow's immutable source inputs and exact-head artifact.
  • Reconciled the embedded LKG, composed candidate, and beta canary roles.
  • Closed the package-consumption integrity boundary with fail-closed pre-install verification.
  • Added exact-head GitHub Windows/WSL proof for the composed candidate.
  • Left the historical beta.3 wizard disconnect visible as a non-blocking compatibility signal.
  • Recorded the 2026.7.1 minimum security floor and stable-only forward-update rule in ADR 0001.
  • Maintainer review is pending.

Agent transcript

Redacted operator and agent engineering record
  • The operator kept the ownership boundary clear: Windows Companion owns Windows and WSL setup; OpenClaw owns Gateway behavior and package generation.
  • Core fixes were frozen at exact commits instead of following moving branches indefinitely.
  • After #111956 merged, the composition was reduced to current main plus the exact #110382 patch.
  • The integrity contract was traced into the production Setup Engine rather than implemented only in the E2E harness.
  • Failed-first proof established that an incorrect digest stops before npm. The success path consumes the same verified downloaded tarball.
  • Fresh CI proved the frozen composed artifact through setup, Gateway health, connection, revocation recovery, and network recovery.
  • The historical beta.3 lane still exposes its wizard disconnect. It remains visible but does not define the supported LKG or composed candidate.
  • A later compatibility discussion briefly moved the ordinary fallback back to 2026.6.11; review showed that this crossed a known security floor. The owning fix(setup): validate current OpenClaw package lifecycle #999 layer now records 2026.7.1 as the minimum and keeps composed-main packages separate.
  • Raw sessions, local paths, credentials, private messages, tokens, and unrelated operator data are excluded.

@TheAngryPit
TheAngryPit force-pushed the codex/native-new-session-companion branch from 2257b8b to 953c7cc Compare July 16, 2026 07:41
@TheAngryPit TheAngryPit changed the title fix: restore native new sessions and invariant UI counts fix: use invariant PT-PT formatting and update OpenClaw LKG Jul 16, 2026
@clawsweeper

clawsweeper Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codex review: needs real behavior proof before merge. Reviewed July 26, 2026, 6:41 AM ET / 10:41 UTC.

ClawSweeper review

What this changes

This PR adds SHA-256 verification for a CI-composed OpenClaw package before Windows Companion setup installs it, changes Gateway service lifecycle and version-specific command-policy handling, and updates CI, documentation, and regression coverage.

Merge readiness

Blocked until stronger real behavior proof is added - 7 items remain

Keep open. The PR contains substantive package-integrity and setup-lifecycle work, but its current head does not yet have inspectable current-head real-run output and its required test/E2E jobs remain in progress. It also establishes a CI-composed candidate using a frozen patch from an unmerged external OpenClaw fork, which needs an explicit maintainer support and provenance decision. Likely related people: CassieMei appears to be the primary implementation contributor in this PR's commit history, with low confidence for current-main ownership because local history inspection was blocked.

Priority: P1
Reviewed head: f5958e2190e5484a40ce551783765c0637a1786a
Owner decision: Required. See Decision needed.

Review scores

Measure Result What it means
Overall readiness 🦪 silver shellfish (2/6) The patch has useful integrity hardening and broad regression coverage, but current-head runtime proof and maintainer-approved provenance are still missing.
Proof confidence 🦪 silver shellfish (2/6) Needs stronger real behavior proof before merge: The PR body describes after-fix disposable Windows/WSL behavior, but the final head lacks inspectable current-head output or artifacts and its required runtime checks are still in progress; add redacted terminal/live output after they finish. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Patch quality 🦐 gold shrimp (3/6) Security review found an item that needs attention.

Verification

Check Result Evidence
Real behavior Needs proof Needs stronger real behavior proof before merge: The PR body describes after-fix disposable Windows/WSL behavior, but the final head lacks inspectable current-head output or artifacts and its required runtime checks are still in progress; add redacted terminal/live output after they finish. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed 5 items Current-head proof is not inspectable: The PR body asserts composed setup-and-connect and checksum fail-closed behavior on head f5958e2, but provides no attached terminal output, runtime log, or artifact demonstrating that final head; the supplied check state still shows the test job and five E2E lanes in progress.
External composed-source boundary: The CI diff creates a gateway-composed job that checks out frozen upstream source and applies a patch fetched from TheAngryPit/openclaw before building the candidate archive. The fixed commit and patch hash reduce substitution risk, but the resulting long-lived CI provenance policy is still a maintainer decision.
Upgrade-sensitive setup changes: The patch changes the embedded official LKG from 2026.6.11 to 2026.7.1, introduces ExpectedPackageSha256, changes the default reload mode to hybrid, and replaces the default pipeline's start step with health polling and reordered keepalive startup.
Findings None None.
Security Needs attention Approve the external patch provenance: The gateway-composed workflow builds a package after fetching a fixed patch from TheAngryPit/openclaw. Immutable commit and patch hashes limit mutation, but maintainers still need to accept the external source and define when it is replaced by official upstream provenance.

How this fits together

Windows Companion provisions a WSL-hosted OpenClaw Gateway, configures the Gateway's node-command policy, waits for it to become healthy, and pairs it with the Windows node. This PR changes package selection and integrity validation before installation, plus the service lifecycle steps that follow installation.

flowchart LR
  SetupConfig[Setup configuration] --> PackageSelect[Gateway package selection]
  PackageSelect --> DigestVerify[SHA-256 verification]
  DigestVerify --> GatewayInstall[Gateway install and activation]
  GatewayInstall --> HealthCheck[Gateway health check]
  HealthCheck --> Pairing[Gateway and node pairing]
  Pairing --> WindowsNode[Windows node services]
Loading

Decision needed

Question Recommendation
Should this repository permanently maintain a CI-composed Gateway candidate built by applying a frozen patch from an unmerged external OpenClaw fork, or wait for a merged upstream commit or official release instead? Wait for upstream provenance: Keep this PR open until the required upstream fix is merged or released, then compose from official OpenClaw history and rerun the exact-head proof.

Why: The code can pin commit and patch hashes, but maintainers must decide whether that external provenance and ongoing cross-repository support burden are acceptable for this repository's validation contract.

Before merge

  • Add real behavior proof - Needs stronger real behavior proof before merge: The PR body describes after-fix disposable Windows/WSL behavior, but the final head lacks inspectable current-head output or artifacts and its required runtime checks are still in progress; add redacted terminal/live output after they finish. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
  • Resolve security concern: Approve the external patch provenance - The gateway-composed workflow builds a package after fetching a fixed patch from TheAngryPit/openclaw. Immutable commit and patch hashes limit mutation, but maintainers still need to accept the external source and define when it is replaced by official upstream provenance.
  • Resolve merge risk (P1) - The exact current head has no inspectable real Windows/WSL success-and-failure proof in the supplied PR materials, while its required test and E2E checks are still running.
  • Resolve merge risk (P1) - Merging would establish a maintained CI path that composes and executes a Gateway package from an unmerged patch fetched from an external fork; fixed hashes mitigate mutation but do not settle long-term provenance and support ownership.
  • Resolve merge risk (P1) - The default setup path, Gateway version floor, service activation ordering, reload behavior, and command-policy schema all change together, so fresh-install and upgrade behavior need completed current-head E2E confirmation.
  • Complete next step (P2) - Maintainters must decide the external composed-package provenance policy and wait for exact-head setup/E2E evidence; this is not a safe automated repair task.

Findings

  • [medium] Approve the external patch provenance — .github/workflows/ci.yml:26
Agent review details

Security

Needs attention: The package hash checks are a positive control, but the new CI-composition path fetches an unmerged patch from an external fork and needs explicit maintainer provenance approval before it becomes a durable validation dependency.

Review metrics

Metric Value Why it matters
Patch surface 40 files affected, 3,471 added, 205 removed The branch combines setup runtime behavior, CI composition, documentation, and several test layers, so it needs full current-head integration evidence.
Runtime gate state 1 test job and 5 E2E jobs in progress The pending jobs cover the exact setup paths changed by the PR and should complete before merge confidence is raised.

Merge-risk options

Maintainer options:

  1. Establish supported provenance before merge (recommended)
    Require a maintainer decision on the frozen external patch source, then attach current-head Windows/WSL evidence for both the official fallback and composed candidate.
  2. Wait for an official upstream artifact
    Pause this branch until the upstream wizard fix is merged or released, replace the fork-patch input with official provenance, and refresh the end-to-end proof.
  3. Accept an explicitly experimental CI lane
    If maintainers want candidate coverage now, make it non-supporting and non-gating while retaining official-artifact proof as the merge contract.

Technical review

Best possible solution:

Keep ordinary installs on the official 2026.7.1 fallback, require maintainer approval for any long-lived composed-package provenance, and merge only after current-head disposable Windows/WSL evidence proves both successful installation and checksum mismatch rejection before npm.

Do we have a high-confidence way to reproduce the issue?

No. The PR describes disposable Windows/WSL proof, but the supplied materials do not include inspectable current-head terminal output, logs, or artifacts, and the relevant exact-head E2E jobs are still in progress.

Is this the best way to solve the issue?

Unclear. SHA-256 verification before installation is a sound boundary, but a permanent composed-package lane based on an unmerged external patch is not clearly the narrowest supported solution until maintainers decide its provenance policy.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against f50af187865c.

Labels

Label changes:

  • add rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🦐 gold shrimp.
  • remove rating: 🦐 gold shrimp: Current PR rating is rating: 🦪 silver shellfish, so this older rating label is no longer current.

Label justifications:

  • P1: This PR changes the setup path that provisions the Gateway used by Windows Companion users.
  • merge-risk: 🚨 compatibility: It changes the default Gateway version, package configuration contract, reload mode, command-policy schema selection, and setup pipeline ordering.
  • merge-risk: 🚨 security-boundary: It adds a package-integrity boundary and a CI candidate assembled from a fixed patch fetched from an external fork.
  • merge-risk: 🚨 availability: It changes service activation, restart ownership, port ownership checks, recovery state, and health-wait sequencing during onboarding.
  • rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🦐 gold shrimp.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs stronger real behavior proof before merge: The PR body describes after-fix disposable Windows/WSL behavior, but the final head lacks inspectable current-head output or artifacts and its required runtime checks are still in progress; add redacted terminal/live output after they finish. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Evidence

Security concerns:

  • [medium] Approve the external patch provenance — .github/workflows/ci.yml:26
    The gateway-composed workflow builds a package after fetching a fixed patch from TheAngryPit/openclaw. Immutable commit and patch hashes limit mutation, but maintainers still need to accept the external source and define when it is replaced by official upstream provenance.
    Confidence: 0.89

What I checked:

  • Current-head proof is not inspectable: The PR body asserts composed setup-and-connect and checksum fail-closed behavior on head f5958e2, but provides no attached terminal output, runtime log, or artifact demonstrating that final head; the supplied check state still shows the test job and five E2E lanes in progress. (f5958e2190e5)
  • External composed-source boundary: The CI diff creates a gateway-composed job that checks out frozen upstream source and applies a patch fetched from TheAngryPit/openclaw before building the candidate archive. The fixed commit and patch hash reduce substitution risk, but the resulting long-lived CI provenance policy is still a maintainer decision. (.github/workflows/ci.yml:26, f5958e2190e5)
  • Upgrade-sensitive setup changes: The patch changes the embedded official LKG from 2026.6.11 to 2026.7.1, introduces ExpectedPackageSha256, changes the default reload mode to hybrid, and replaces the default pipeline's start step with health polling and reordered keepalive startup. (src/OpenClaw.SetupEngine/SetupPipeline.cs:61, f5958e2190e5)
  • Related umbrella work: The open umbrella report explicitly identifies this PR as its bounded stable-alignment implementation, while retaining broader release-alignment and ownership work outside this branch. (f5958e2190e5)
  • Implementation provenance: All 19 supplied branch commits are authored by CassieMei, including the final secure-stable-floor commit f5958e2. This identifies a likely implementation routing contact, not current-main ownership. (src/OpenClaw.SetupEngine/GatewayLkgVersion.cs:6, f5958e2190e5)

Likely related people:

  • CassieMei: The supplied pull-request commit history attributes all 19 commits, including the package verification, lifecycle, policy, CI, and final security-floor changes, to CassieMei. (role: primary implementation contributor; confidence: low; commits: d4c373dff785, e776e5fa2d4d, 8b614c33091d; files: .github/workflows/ci.yml, src/OpenClaw.SetupEngine/SetupPipeline.cs, src/OpenClaw.SetupEngine/SetupSteps.cs)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Attach redacted current-head Windows/WSL output showing composed success, official-LKG setup, and checksum rejection before npm.
  • Obtain a maintainer decision on whether the frozen external OpenClaw patch may remain a CI provenance input.
  • After proof is added, update the PR body to trigger a fresh ClawSweeper review; ask a maintainer to comment @clawsweeper re-review if it does not run automatically.

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (30 earlier review cycles; latest 8 shown)
  • reviewed 2026-07-19T11:21:00.122Z sha 4f75f7d :: needs real behavior proof before merge. :: [P1] Keep the default on a setup-proven official artifact
  • reviewed 2026-07-19T14:13:11.207Z sha 7f3b863 :: needs real behavior proof before merge. :: [P1] Keep the default on a setup-proven official artifact
  • reviewed 2026-07-19T14:54:44.775Z sha 7f3b863 :: needs real behavior proof before merge. :: [P1] Keep the default on a setup-proven official artifact
  • reviewed 2026-07-25T08:30:59.635Z sha 434af02 :: needs real behavior proof before merge. :: [P1] Keep the default on a setup-proven official artifact
  • reviewed 2026-07-25T21:31:36.481Z sha 8b3d57f :: needs real behavior proof before merge. :: [P1] Keep the default on a setup-proven official artifact
  • reviewed 2026-07-25T23:58:38.442Z sha 1f785aa :: needs real behavior proof before merge. :: [P1] Align frozen provenance with the workflow inputs
  • reviewed 2026-07-26T02:17:39.221Z sha 1f785aa :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-26T10:34:29.232Z sha f5958e2 :: needs real behavior proof before merge. :: none

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P1 Urgent regression or broken agent/channel workflow affecting real users now. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. merge-risk: 🚨 availability 🚨 Merging this PR could cause crashes, hangs, restart loops, stalls, or process outages. labels Jul 16, 2026
@TheAngryPit TheAngryPit changed the title fix: use invariant PT-PT formatting and update OpenClaw LKG fix: stabilize OpenClaw beta setup and PT-PT formatting Jul 16, 2026
@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Jul 16, 2026
@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Jul 17, 2026
TheAngryPit pushed a commit to TheAngryPit/openclaw-windows-node that referenced this pull request Jul 17, 2026
@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Jul 17, 2026
@TheAngryPit
TheAngryPit marked this pull request as ready for review July 17, 2026 14:47
@TheAngryPit
TheAngryPit marked this pull request as draft July 17, 2026 14:49
@TheAngryPit

Copy link
Copy Markdown
Contributor Author

Status update after current-main integration and fresh official-package validation:

  • The PR head is 031c665b804ec185ad30279a2c551cdc2b68986a and remains mergeable.
  • The final public branch passes Setup Engine 438/438; focused stable-version/schema tests pass 4/4; git diff --check passes.
  • Scoped Codex Auto-review found zero issues (patch is correct, confidence 0.97).
  • The repository-built Companion installer completed successfully in a disposable Windows VM. MXC selected appcontainer-dacl; the bounded allow case passed and the outside-root write was denied without creating a file.
  • All three GitHub WSL setup shards installed official OpenClaw 2026.7.1, then failed at the same upstream start-gateway startup-migration lease regression tracked by [Bug]: update to openclaw 2026.7.1: gateway fails to start w/ error openclaw#108435. Later scenario failures are cascades, not three separate Companion failures.
  • OpenClaw 2026.7.2-beta.2 release notes include the matching lease-release fix, but this PR intentionally does not silently make a prerelease the stable Companion default.

The PR body now contains the full failed-first evidence, scope, validation, and sanitized operator/agent decision record. I am marking it ready so maintainers can review the actual tradeoff rather than leaving the work hidden in draft. This is not a claim that the known stable-package E2E blocker is resolved.

No maintainer or automerge action is requested here. @clawsweeper re-review

@TheAngryPit
TheAngryPit marked this pull request as ready for review July 17, 2026 14:50
@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Jul 17, 2026
@TheAngryPit

Copy link
Copy Markdown
Contributor Author

Current-head proof update:

  • Head prepared locally: 9c308f0bd13948ccfd3c39d0e7373914fa8d6801, integrated with upstream main 4518dd87ed2bbfbdb3e1389cd88e2bc95141ea2b.
  • Build passed with zero warnings/errors.
  • Fresh suites passed: Connection 443/443, SetupEngine 448/448, Tray 1742/1742, Shared 2866 plus 31 explicit integration skips.
  • Disposable Companion-owned WSL revocation/reconnect E2E passed 1/1 and completed uninstall/teardown.
  • Strict Gateway -> Windows Node -> MXC E2E passed 2/2 without skip allowance, including the protected-write denial, and completed uninstall/teardown.
  • Official OpenClaw 2026.7.2-beta.2 still reproduces the native wizard Gateway-loss defect. The successful E2E explicitly injected a separately scoped OpenClaw wizard-runtime correction after the normal official install; that correction is not part of this Companion PR.
  • Final scoped Auto-review produced one restart/uninstall claim, rejected by direct call-path inspection because the restart helper contains no uninstall call. Accepted actionable findings: zero.

The PR body now distinguishes the Companion fixes from the remaining OpenClaw core dependency and requests review of the beta-default contract. @clawsweeper re-review

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jul 25, 2026

Copy link
Copy Markdown

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

@TheAngryPit
TheAngryPit force-pushed the codex/native-new-session-companion branch from 434af02 to 8b3d57f Compare July 25, 2026 21:27
@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Jul 26, 2026
@TheAngryPit

Copy link
Copy Markdown
Contributor Author

Security-floor correction published

Current head: f5958e2190e5484a40ce551783765c0637a1786a

This update corrects the ordinary Gateway fallback at the layer that owns it:

  • restores official stable 2026.7.1 as the minimum security floor;
  • records the decision in docs/adr/0001-gateway-lkg-security-floor.md;
  • permits automation to move only to a strictly newer exact stable release;
  • rejects prereleases, equal versions, and downgrades;
  • keeps composed-main packages on their separate immutable version, URI, and SHA-256 contract.

Fresh local proof on the exact commit:

  • focused SetupEngine: 3/3;
  • complete Release build: passed;
  • Shared: 3,232 passed with 31 declared environment-dependent skips;
  • Tray: 1,958/1,958;
  • YAML parse and forward/equal/downgrade policy simulation: passed;
  • scoped Auto-review: no findings, patch is correct, confidence 0.95.

GitHub checks started automatically from the push. No manual ClawSweeper re-review command was added.

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 availability 🚨 Merging this PR could cause crashes, hangs, restart loops, stalls, or process outages. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. P1 Urgent regression or broken agent/channel workflow affecting real users now. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants