Install missing build tools on Linux #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wtfloris is attempting to deploy a commit to the Amantus Machina Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| elif command -v yum &> /dev/null; then | ||
| maybe_sudo yum groupinstall -y "Development Tools" | ||
| fi | ||
| echo -e "${SUCCESS}✓${NC} Build tools installed" |
There was a problem hiding this comment.
Silent failure in build tools installation: if no package manager is detected, the script prints success message even though nothing was installed
- Install build-essential on Debian/Ubuntu - Install Development Tools + gcc-c++ on Fedora/RHEL - Ensures make and g++ are available for native module compilation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing this on a fresh VM that didn't have
makeorg++installed by default, the install script fails. This PR adds those requirements to the install script.