Conversation
We can't really know if the user really rated, but at least this PR will make Juergen happy. For #38
Contributor
Author
|
@jnweiger @TheOneRing ping ^ |
jnweiger
reviewed
Jan 24, 2026
There was a problem hiding this comment.
APP_RATER_PREF_DONT_SHOW is never reset to false, is it?
It seems to me, we won't get any reviews again, ever. Please clarify, if or when the dialog could show up again.
I'd be happy to get the RateMeDialog maybe once for every new version i upgraded to... or maybe again after 100 days, or so.
Contributor
Author
|
APP_RATER_PREF_DONT_SHOW is the exact same behaviour as pressing the "No, thanks" button :) If you insist, I can check the idea that you had and maybe just delay it more. But it's still risky and could annoy the user because they can see/remember that they rated already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't really know if the user really rated, but at least this PR will make Juergen happy.
For #38