-
Notifications
You must be signed in to change notification settings - Fork 25
feat: adjust preview app loading #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
212660b to
062eda5
Compare
2be1d69 to
dfb3c26
Compare
0db1afe to
598e5ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can’t rely on requesting a preview at this point. When files are opened from the tiles view, all images in the photo roll are already loaded. If, for example, an MP4 file is opened, it doesn’t provide a preview flag via PROPFIND, so we don’t make any preview-endpoint requests here.
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! 😍
I found a tiny edge case for the photo roll preview: when you delete and file and then restore it via the button in the notification, the file re-appears in the photo roll and is clickable and everything, but the thumbnail doesn't load. Maybe something for a followup though 😅
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.... forgot in my review to switch from Comment to Approve. 🙈 sorry.
|
Thank you, I will do the enhancements in the following pr which is about the photo roll improvements |
Description
<script setup>filteredFilesandcachedFilesprops into a single propmediaFilesRelated Issue
How Has This Been Tested?
Types of changes