Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Feb 2, 2026

Description

  • Refactored component to <script setup>
  • Merged filteredFiles and cachedFiles props into a single prop mediaFiles
  • Cancel ongoing image loading when quickly skipping to another image before loading completes
  • Decoupled photo roll previews

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear changed the title refactor feat: adjust preview app loading Feb 2, 2026
@AlexAndBear AlexAndBear force-pushed the preview-app-improvements branch from 212660b to 062eda5 Compare February 2, 2026 22:05
@AlexAndBear AlexAndBear requested a review from kulmann February 2, 2026 22:06
@AlexAndBear AlexAndBear marked this pull request as ready for review February 2, 2026 22:06
@AlexAndBear AlexAndBear force-pushed the preview-app-improvements branch from 2be1d69 to dfb3c26 Compare February 2, 2026 23:52
@AlexAndBear AlexAndBear force-pushed the preview-app-improvements branch from 0db1afe to 598e5ff Compare February 3, 2026 11:08
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can’t rely on requesting a preview at this point. When files are opened from the tiles view, all images in the photo roll are already loaded. If, for example, an MP4 file is opened, it doesn’t provide a preview flag via PROPFIND, so we don’t make any preview-endpoint requests here.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 😍

I found a tiny edge case for the photo roll preview: when you delete and file and then restore it via the button in the notification, the file re-appears in the photo roll and is clickable and everything, but the thumbnail doesn't load. Maybe something for a followup though 😅

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... forgot in my review to switch from Comment to Approve. 🙈 sorry.

@AlexAndBear
Copy link
Contributor Author

Thank you, I will do the enhancements in the following pr which is about the photo roll improvements

@AlexAndBear AlexAndBear merged commit 6aa5a38 into main Feb 3, 2026
28 checks passed
@AlexAndBear AlexAndBear deleted the preview-app-improvements branch February 3, 2026 15:24
@openclouders openclouders mentioned this pull request Feb 3, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preview app: Reasonable preloading

3 participants