Skip to content

chore: don't expose access token in the ui #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexAndBear merged 3 commits into from
Feb 6, 2026
Merged

chore: don't expose access token in the ui #1942

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d79de4c
chore: don't expose access token in the ui
AlexAndBear Feb 6, 2026
82654bc
remove more logging
AlexAndBear Feb 6, 2026
c1b6c88
chore: don't expose access token in the ui
AlexAndBear Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/web-runtime/src/services/auth/authService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,18 +140,18 @@ export class AuthService implements AuthServiceInterface {
const fetchUserData = !isIdpContextRequired(this.router, to)

if (!this.userManager.areEventHandlersRegistered) {
this.userManager.events.addAccessTokenExpired((...args): void => {
this.userManager.events.addAccessTokenExpired((): void => {
const handleExpirationError = () => {
console.error('AccessToken Expired：', ...args)
console.error('AccessToken Expired')
this.handleAuthError(unref(this.router.currentRoute), { forceLogout: true })
}

// retry silent signin once, force logout if it fails
this.userManager.signinSilent().catch(handleExpirationError)
})

this.userManager.events.addAccessTokenExpiring((...args) => {
console.debug('AccessToken Expiring：', ...args)
this.userManager.events.addAccessTokenExpiring(() => {
console.debug('AccessToken Expiring')
})

this.userManager.events.addUserLoaded(async (user) => {
Expand All @@ -160,9 +160,7 @@ export class AuthService implements AuthServiceInterface {
expiryThreshold: this.accessTokenExpiryThreshold
})

console.debug(
`New User Loaded. access_token： ${user.access_token}, refresh_token: ${user.refresh_token}`
)
console.debug(`New User Loaded`)
try {
await this.userManager.updateContext(user.access_token, fetchUserData)
} catch (e) {
Expand All @@ -172,7 +170,7 @@ export class AuthService implements AuthServiceInterface {
})

this.userManager.events.addUserUnloaded(() => {
console.log('user unloaded…')
console.log('User Unloaded')
this.tokenTimerWorker?.resetTokenTimer()
this.resetStateAfterUserLogout()

Expand Down