Fix auth ssr initial cache state (#10601)

* Handle case where pageProps initial cache is undefined

* Use cache only fetch policy on ssr

components/dashboard/sections/accounts/index.tsx

@@ -106,7 +106,7 @@ const Accounts = ({ accountSlug, subpath }: DashboardSectionProps) => {
   const { data, error, loading, refetch } = useQuery(accountsQuery, {
     variables: { accountSlug, ...queryFilter.variables },
     context: API_V2_CONTEXT,
-    fetchPolicy: 'cache-and-network',
+    fetchPolicy: typeof window !== 'undefined' ? 'cache-and-network' : 'cache-first',
   });
   useEffect(() => {
     if (subpath[0] !== ((showCollectiveOverview as Collective)?.id || showCollectiveOverview)) {

components/dashboard/sections/collectives/HostApplications.tsx

@@ -105,12 +105,13 @@ const HostApplications = ({ accountSlug: hostSlug }: DashboardSectionProps) => {
 
   const { data, error, loading } = useQuery(hostApplicationsQuery, {
     variables: { hostSlug, ...queryFilter.variables },
-    fetchPolicy: 'cache-and-network',
     context: API_V2_CONTEXT,
   });
 
   // Open application account id, checking hash for backwards compatibility
-  const accountId = Number(router.query.accountId || window?.location.hash.split('application-')[1]);
+  const accountId = Number(
+    router.query.accountId || (typeof window !== 'undefined' && window?.location.hash.split('application-')[1]),
+  );
   const [applicationInDrawer, setApplicationInDrawer] = React.useState(null);
   const drawerOpen = accountId && applicationInDrawer;
 

components/dashboard/sections/contributions/Contributions.tsx

@@ -530,7 +530,7 @@ const Contributions = ({ accountSlug, direction, onlyExpectedFunds, includeHoste
       includeHostedAccounts: !!includeHostedAccounts,
     },
     context: API_V2_CONTEXT,
-    fetchPolicy: 'cache-and-network',
+    fetchPolicy: typeof window !== 'undefined' ? 'cache-and-network' : 'cache-first',
   });
 
   const selectedContributionId = router.query.orderId ? parseInt(router.query.orderId as string) : null;
@@ -689,7 +689,7 @@ const Contributions = ({ accountSlug, direction, onlyExpectedFunds, includeHoste
         : { expectedFundsFilter: null }),
     },
     context: API_V2_CONTEXT,
-    fetchPolicy: 'cache-and-network',
+    fetchPolicy: typeof window !== 'undefined' ? 'cache-and-network' : 'cache-first',
   });
 
   const [editOrder, setEditOrder] = React.useState<{ order?: { id: string | number }; action: EditOrderActions }>({

pages/_app.js

@@ -159,7 +159,7 @@ class OpenCollectiveFrontendApp extends App {
 
   getApolloClient = memoizeOne((ssrCache, pageServerSidePropsCache) => {
     return initClient({
-      initialState: mergeDeep(ssrCache, pageServerSidePropsCache),
+      initialState: mergeDeep(ssrCache || {}, pageServerSidePropsCache || {}),
       twoFactorAuthContext: this.props.twoFactorAuthContext,
     });
   });