Add project search to project section in collective page #10646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Betree
reviewed
Sep 11, 2024
Betree
reviewed
Sep 11, 2024
Comment on lines
143
to
147
| <Input | ||
| placeholder={intl.formatMessage({ defaultMessage: 'Search projects...', id: 'Dw9Bae' })} | ||
| type="search" | ||
| value={searchTerm} | ||
| onChange={e => setSearchTerm(e.target.value)} | ||
| /> |
There was a problem hiding this comment.
Maybe display this one if there are more than 10 projects total? Collectives with only 3 projects won't need a search bar there.
There was a problem hiding this comment.
Marking this one as unresolved as it doesn't seem addressed:
hdiniz
force-pushed
the
add-project-search
branch
from
e5583a3 to
3104b2b
Compare
Betree
reviewed
Sep 26, 2024
There was a problem hiding this comment.
-
The empty view looks a bit broken, could we use something more standard? You can look at https://github.com/opencollective/opencollective-frontend/blob/add-project-search/components/dashboard/EmptyResults.tsx for some inspiration.
-
The loading state also looks a bit strange, the spinner takes some time to appear and "No results match your search" appears along with it:
Screencast.from.2024-09-26.09-01-37.webm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related opencollective/opencollective#7535
Require opencollective/opencollective-api#10311