Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Collective profile prototype #10678

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Update Collective profile prototype #10678

merged 2 commits into from
Dec 2, 2024

Conversation

gustavlrsn
Copy link
Member

@gustavlrsn gustavlrsn commented Oct 2, 2024

For opencollective/opencollective#7534

Description

Updates the Collective profile prototype including:

  • home page with the about text and tiers on the main account
  • list of projects/events below
  • a "Finances" page with an overview of all accounts and their balance, received and spent amounts
  • on this page you can also click into an account to view transaction (groups) on that account that you can open and get (eventually) linked to the underlying expenses and contributions
  • an "Updates" page

Screenshots

Screenshot 2024-11-27 at 17 16 29 Screenshot 2024-11-27 at 17 16 37 Screenshot 2024-11-27 at 17 16 47

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 11:43am
opencollective-styleguide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 11:43am

@gustavlrsn gustavlrsn marked this pull request as ready for review November 14, 2024 13:14
@gustavlrsn gustavlrsn force-pushed the collective-profile branch 2 times, most recently from 230215a to 0e4e4de Compare November 25, 2024 13:05
@gustavlrsn gustavlrsn requested a review from Betree November 27, 2024 16:22
Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some margin below projects
image

className={linkClasses()}
onClick={triggerPrototypeToast}
>
<Interweave content={heading} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need Interweave here, since it's extracted with textContent it's not supposed to contain HTML, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure how safe it was to use textContent directly, but looks like it's safe, I've removed Interweave here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants