-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Collective profile prototype #10678
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
20db272
to
a3201a3
Compare
62a6f0d
to
f875650
Compare
f875650
to
34fe768
Compare
34fe768
to
1de3c88
Compare
1de3c88
to
0daa1b1
Compare
0daa1b1
to
93d92b9
Compare
230215a
to
0e4e4de
Compare
0e4e4de
to
b18719b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className={linkClasses()} | ||
onClick={triggerPrototypeToast} | ||
> | ||
<Interweave content={heading} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need Interweave
here, since it's extracted with textContent
it's not supposed to contain HTML, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure how safe it was to use textContent
directly, but looks like it's safe, I've removed Interweave here
b18719b
to
7f95cc8
Compare
7f95cc8
to
5352159
Compare
For opencollective/opencollective#7534
Description
Updates the Collective profile prototype including:
Screenshots