address rc

Author: senthilsam

pkg/app/app.go

@@ -230,15 +230,14 @@ func (a *App) PreRunE(cmd *cobra.Command, args []string) error {
 	if a.Config.EnablePprof {
 		_, _, err := net.SplitHostPort(a.Config.GlobalFlags.PprofAddr)
 		if err != nil {
-			fmt.Printf("pprof error %v", err)
-		} else {
-			a.pprof.Start(a.Config.GlobalFlags.PprofAddr)
-			a.Logger.Printf("pprof server started at %s/debug/pprof", a.Config.GlobalFlags.PprofAddr)
-			go func() {
-				err := <-a.pprof.ErrChan()
-				a.Logger.Printf("pprof server failed: %v", err)
-			}()
+			return fmt.Errorf("pprof error %v", err)
 		}
+		a.pprof.Start(a.Config.GlobalFlags.PprofAddr)
+		a.Logger.Printf("pprof server started at %s/debug/pprof", a.Config.GlobalFlags.PprofAddr)
+		go func() {
+			err := <-a.pprof.ErrChan()
+			a.Logger.Printf("pprof server failed: %v", err)
+		}()
 	}
 
 	a.Config.SetGlobalsFromEnv(a.RootCmd)