-
Notifications
You must be signed in to change notification settings - Fork 681
Update openconfig-bgp-common.yang to support ExRR #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Support for extended route retention (ERR)
Added container for extended-route-retention under container graceful-restart.
Update for ERR support
Update for ERR support
Update for ERR addition.
Update for ERR addition
Update for ERR addition.
Indentation fix
Added ERR under AFI section of Global BGP config
ERR definition at Neighbor level and Neighbor AFI/SAFI level.
Added ERR under AFI/SAFI level
Indentation cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the same thing as https://datatracker.ietf.org/doc/html/rfc9494 ? If so, please modify naming and add a reference to rfc9494 similar to other OC models which reference RFCs
/gcbrun |
No major YANG version changes in commit a154667 |
No. This is DIFFERENT then RFC9494. It is non device local behaviour.
|
|
Updating from 9.9.2 to 9.10.0
9.9.2 to 9.10.0
9.9.2 to 9.10.0
9.9.2 to 9.10.0
9.9.2 to 9.10.0
9.9.2 to 9.10.0
9.9.2 to 9.10.0
Addressing comments: - Enable policy chaining: The retention-policy node is changed from a leaf to a leaflist to allow an operator to apply an ordered chain of multiple routing policies - Add Explicit and Reusable Default Policy: Is reusing the existing oc-pol-types:default-policy-type - Add Operational State for ERR
Updated to include "bgp-extended-route-retention-state"
Update to include bgp-extended-route-retention-state;
Updates to include bgp-extended-route-retention-state for state.
ERR --> ExRR
ERR --> ExRR
ERR --> ExRR
ERR --> ExRR
ERR --> ExRR
ERR --> ExRR
/gcbrun |
Updated ERR --> ExRR
modified line on LLGR based on review feedback
Correction to remaining-retention-time with more clarity
/gcbrun |
are meaningfull only under neighbor and neighor/afi-safi.
i description tree for |
Support for extended route retention (ERR) which is an extension to graceful restart.
Scope of Change:
This pull request introduces a new feature to the OpenConfig BGP model called BGP Extended Route Retention (ExRR). This feature provides a mechanism for a BGP speaker to retain stale routes from a failed peer for a long, configurable duration, independent of standard Graceful Restart timers.
The core of this feature is a flexible, policy-driven approach. Key changes include:
A new bgp-extended-route-retention-config grouping is added to openconfig-bgp-common.yang . This grouping includes new configuration leaves such as:
A new bgp-extended-route-retention-state grouping is added to provide operational state, including extended-retention-active to indicate if the feature is active and remaining-retention-time to show the time left before routes are purged.
The description clarifies that this feature is distinct from the IETF's Long-Lived Graceful Restart (LLGR, RFC 9494) because ExRR is a purely local behavior that does not require BGP capability negotiation .
These new configuration and state capabilities have been added to the BGP model at the global, peer-group, and neighbor levels to allow for flexible application.
Current vendor implementations
Snippet of different proposals below
Path: network-instances/network-instance/protocols/protocol/bgp/global/graceful-restart
Pat: network-instances/network-instance/protocols/protocol/bgp/global/afi-safis/afi-safi/graceful-restart
Path: network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/graceful-restart
Path: network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/afi-safis/afi-safi/graceful-restart
Path: network-instances/network-instance/protocols/protocol/bgp/peer-groups/peer-group/graceful-restart
Path: network-instances/network-instance/protocols/protocol/bgp/peer-groups/peer-group/afi-safis/afi-safi/graceful-restart