-
Notifications
You must be signed in to change notification settings - Fork 682
Platform model for USB port #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixed version number.
/gcbrun |
No major YANG version changes in commit b340803 |
Fixed trailing whitespace.
Fixed trailing whitespace.
Resolved trailing whitespace issue that caused previous tests to fail. |
Updated descriptions to be more general & reflect boolean statement rather than importing `power-admin-state`.
/gcbrun |
Removed "default true;".
/gcbrun |
Reviewed in September 4, 2025 OC Community meeting without objections. I'll wait to move this to last call until @ThatOneSix has reviewed this with more implementors. @ThatOneSix let me know when you have internal sign off on this approach and we can move it to a last call status and then merge. |
The tree in the PR description implies that each component may have a At the same time, the PR content shows that you introduce a new component type identity, which implies that a port is modelled as a separate entity. Could you please clarify this? Is your intention to support both models (usb ports as separate components and usb ports as a property of other components)? |
/gcbrun |
My intent is to model USB ports as their own components. To view the tree another way:
So it is on the same level as something like |
In the component model, it's typical for a component of type The YANG modules don't contain constraints to enforce this, but it doesn't mean that we expect to have containers named |
Is there a specific reason behind this choice?
Only the ones that have such ports :-). There's nothing in OC community that says this is invalid, it is a choice vendors can make. |
Can you give an example of what you are suggesting regarding "inlining usb ports to the parent components"?
Yes, this flexibility is intentional and up to implementors to decide what relationship is appropriate for their hardware. There are some limited expectations encoded into featureprofiles tests. (one example) |
Just placing usb-port container directly under the parent component, e.g. instead of creating a new component with a new identity, such as I don't think either approach is wrong, but the latter seems slightly excessive. But if the community prefers to have an identity as well, that's fine. |
Didn't realize another PR was opened for this - same comment on prior PR #1339 |
Change Scope
Also viewed as:
Platform Implementations
Mobility Controller-based Aruba Access Points: https://arubanetworking.hpe.com/techdocs/CLI-Bank/Content/aos8/ap-system-pro.htm (ap-usb-power-mode [enable|disable])
Cisco Catalyst switches: https://www.cisco.com/c/en/us/td/docs/switches/lan/catalyst9400/software/release/17-17/command_reference/b_1717_9400_cr/interface_and_hardware_commands.html?dtid=osscdc000283&linkclickid=srch#wp3775305635 ([no] platform usb disable)