Add enable-echo leaf to BFD interface config. #1364
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bfd echo mode is defined in RFC 5880: |
dplore
requested changes
Sep 22, 2025
|
|
||
| leaf enable-echo { | ||
| type boolean; | ||
| default false; |
There was a problem hiding this comment.
The RFC doesn't mention any default value for echo mode. (I didn't see it here https://datatracker.ietf.org/doc/html/rfc5880#section-6.8.13). Please remove the default as OC prefers to not define defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Scope
Add the enable-echo leaf in bfd-interface-config to allow BFD echo mode to be enabled per interface.