Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: namspace label key in selectors for netpol #207

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

y-eight
Copy link
Contributor

@y-eight y-eight commented May 27, 2024

Currently, the namespace label selector in the NetworkPolicies that will be created by setting the value networkPolicies.enabled to true is not set properly. The key of the namespace selector in the egress and ingress definition is name but should be kubernetes.io/metadata.name.
The kubenetes docs state that the label kubernetes.io/metadata.name is set automatically and the name label is not compulsorily existing.

@mattray
Copy link
Collaborator

mattray commented May 28, 2024

Needs a minor version bump, I'll do it when I test next

@mattray mattray merged commit 5d870b8 into opencost:main Jun 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants