Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include image digest to prevent supply chain issues #215

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: include image digest to prevent supply chain issues #215

merged 1 commit into from
Jul 3, 2024

Conversation

toscott
Copy link
Collaborator

@toscott toscott commented Jul 1, 2024

fixes #214

@toscott
Copy link
Collaborator Author

toscott commented Jul 1, 2024

Opted to include it in the tag over making a separate digest to keep the image tag configuration in one spot and preserve backward compatibility with anyone already explicitly overriding the image tag.

@toscott toscott requested a review from mattray July 3, 2024 02:16
mattray
mattray approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@mattray mattray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with my local testing for both arm64 and amd64 with the SHA.

@mattray mattray merged commit 690c0db into opencost:main Jul 3, 2024
1 check passed
@toscott toscott deleted the feat/include-digest branch July 8, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattray mattray mattray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include image digest for containers
2 participants
@toscott @mattray