Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _helpers.tpl #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

thunderthome
Copy link

Make sure that prometheus internal enabled really works (that i can disable it).

Make sure that prometheus internal enabled really works (that i can disable it).

Signed-off-by: thunderthome <[email protected]>
@toscott
Copy link
Collaborator

toscott commented Aug 20, 2024

Hi @thunderthome. Can you help me understand the use case here?

Opencost requires a prometheus endpoint. The options are basically an external one or an internal one. If its internal, the network policy gets added (which doesn't hurt to add if its an external prometheus, so its just defaulted on.

@thunderthome
Copy link
Author

@toscott the reason I want to add this is because now if I turn on Thanos my values aren't used because it has the fallback in the prometheus setup. I wanted to use it internally at first, but one of my colleagues pointed to me that we use Thanos. Now if I want to enable Thanos and disable internal Prometheus it won't let me do that because of this fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants