Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make imagePullPolicy properties configurable #89

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Jun 28, 2023

The PR makes imagePullPolicy properties configurable with default value IfNotPresent for exporter and ui containers.
The PR includes minor README changes rendered by helm-docs run.

Copy link
Contributor

@petewall petewall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image pull policy changes look good. Thanks for updating the docs. I added some comments about possible redundant documentation.

charts/opencost/README.md Outdated Show resolved Hide resolved
charts/opencost/README.md Outdated Show resolved Hide resolved
charts/opencost/README.md Show resolved Hide resolved
charts/opencost/README.md Outdated Show resolved Hide resolved
@dnskr dnskr force-pushed the add_imagePullPolicy_properties branch from 2808c8c to cd205e1 Compare June 28, 2023 22:01
Copy link
Contributor

@petewall petewall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnskr
Copy link
Contributor Author

dnskr commented Jun 28, 2023

The image pull policy changes look good. Thanks for updating the docs. I added some comments about possible redundant documentation.

Totally agree! Thanks for the comment.

@mattray mattray merged commit c6c6c3a into opencost:main Jul 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants