Revert "Merge pull request #1019 from opendata-stuttgart/beta-sen5x", removing SEN5X code for now #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1020 this PR reverts the SEN5X part of #1019.
All SEN5X specific code is removed for now since it appears to introduce stability issues. Other changes (mainly language fixes) are kept.
The [env:d1_mini] in platformio.ini is also reverted to prevent overwriting the nodemcuv2_fr build in build runs.
Note that this is a revert of a merge. Should the SEN5X code be re-added at a later time it can't be done with a new merge from the current beta-sen5x branch. That branch need to be synced again with the beta branch after this PR, followed by a-revert-of-this-revert. Changes to the beta-sen5x branch can then be merged again.