Skip to content

Avoid Null Reference in Core #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SpacemanPaul merged 2 commits into from
Jul 2, 2025
Merged

Avoid Null Reference in Core #2011

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8236c89
Avoid Null Reference in Core
omad May 7, 2025
5faa2ef
Fix another possible null access of dataset.extent
omad Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datacube/api/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1251,7 +1251,7 @@ def select_datasets_inside_polygon(
assert polygon is not None
query_crs = polygon.crs
for dataset in datasets:
if intersects(polygon, dataset.extent.to_crs(query_crs)):
if dataset.extent and intersects(polygon, dataset.extent.to_crs(query_crs)):
yield dataset


Expand Down Expand Up @@ -1321,7 +1321,7 @@ def _fuse_measurement(


def get_bounds(datasets: Iterable[Dataset], crs: CRS) -> Geometry:
bbox = bbox_union(ds.extent.to_crs(crs).boundingbox for ds in datasets)
bbox = bbox_union(ds.extent.to_crs(crs).boundingbox for ds in datasets if ds.extent)
return box(*bbox, crs=crs) # type: ignore[misc]


Expand Down
Loading