1590-1 #1614
Merged
1590-1 #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
kind: documentation
This comment has been minimized.
This comment has been minimized.
anatolii-yemets
added
scope: frontend
AndreyNenashev
requested changes
Feb 9, 2024
odd-platform-ui/src/components/DataQuality/DataQualityContext/DataQualityContext.ts
Outdated
Show resolved
Hide resolved
anatolii-yemets
force-pushed
the
1590-1
branch
from
a3f6141 to
c7d335a
Compare
AndreyNenashev
requested changes
Feb 9, 2024
odd-platform-ui/src/components/DataQuality/DataQualityFilters/DataQualityFiltersStyles.ts
Outdated
Show resolved
Hide resolved
odd-platform-ui/src/components/DataQuality/DataQualityFilters/DataQualityFilters.tsx
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
AndreyNenashev
requested changes
Feb 9, 2024
odd-platform-ui/src/components/DataQuality/DataQualityFilters/DataQualityFilters.tsx
Outdated
Show resolved
Hide resolved
AndreyNenashev
requested changes
Feb 9, 2024
odd-platform-ui/src/components/DataQuality/DataQualityFilters/DataQualityFiltersStyles.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
anatolii-yemets
force-pushed
the
1590-1
branch
from
53d16a0 to
a4e1b7c
Compare
This comment has been minimized.
This comment has been minimized.
AndreyNenashev
requested changes
Feb 13, 2024
odd-platform-ui/src/components/DataQuality/DataQualityFilters/DataQualityFilters.tsx
Outdated
Show resolved
Hide resolved
...lityFilters/FilterItem/MultipleFilterItem/SelectedFilterOption/SelectedFilterOptionStyles.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+13
to
+17
| const hookResult = useHook({ | ||
| page: 1, | ||
| size: 30, | ||
| query: searchText, | ||
| }); |
There was a problem hiding this comment.
I'm not sure how this strict params - page: 1 will work if there are many options to load. I don't see anywhere where we increment this?
There was a problem hiding this comment.
When the searchText changes the results of the 1st page change as well.
So lets say we have 5 entries total
- aaron
- ben
- carol
- ed
- frank
With the size of 3 this will be returned:
- aaron
- ben
- carol
But as soon as the user enters 'e' the result will be:
- ben
- ed
In this example we got ed as a result even though it's out of the first page (for the initial load)
odd-platform-ui/src/components/DataQuality/DataQualityStore/DataQualityStore.ts
Outdated
Show resolved
Hide resolved
...terItem/MultipleFilterItem/MultipleFilterItemAutocomplete/MultipleFilterItemAutocomplete.tsx
Outdated
Show resolved
Hide resolved
...terItem/MultipleFilterItem/MultipleFilterItemAutocomplete/MultipleFilterItemAutocomplete.tsx
Outdated
Show resolved
Hide resolved
|
|
AndreyNenashev
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft version of filters for the data quality screen (#1950)
any feedback is appreciated as there is certainly some questionable decisions present
still TODO: