Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adding a variable for Minio Endpoints #461

Closed
wants to merge 2 commits into from
Closed

WIP: Adding a variable for Minio Endpoints #461

wants to merge 2 commits into from

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Nov 14, 2023

The issue resolved by this Pull Request:

Resolves #375

Description of your changes:

Testing instructions

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dharmitd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DharmitD DharmitD marked this pull request as draft November 14, 2023 22:51
@DharmitD DharmitD changed the title Adding a variable for Minio Endpoints WIP: Adding a variable for Minio Endpoints Nov 14, 2023
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-461

@DharmitD
Copy link
Member Author

Closing as this has been covered in #479

@DharmitD DharmitD closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSPv2] Investigate/Update/Remove minio-service annotation (tekton.dev/artifact_endpoint)
2 participants