Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind Ray ClusterRole to the new operator ServiceAccount #127

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

astefanutti
Copy link
Contributor

Fix a missing update from #125, to bind the Ray ClusterRole to the CodeFlare operator ServiceAccount.

It'll be simplified once project-codeflare/multi-cluster-app-dispatcher#635 is implemented.

@astefanutti
Copy link
Contributor Author

/assign @anishasthana @sutaakar @jbusche

@sutaakar
Copy link
Contributor

/lgtm
Though it doesn't have any effect yet as operator still use cluster edit role.

@openshift-ci openshift-ci bot added the lgtm label Sep 22, 2023
@astefanutti
Copy link
Contributor Author

/lgtm
Though it doesn't have any effect yet as operator still use cluster edit role.

It doesn't seem like Kuberay resources are aggregated to the edit ClusterRole, kubectl get clusterrole edit -o yaml | grep ray doesn't return anything. If that is correct, then it should fixed the RBAC issue reported by @jbusche.

Copy link

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimakis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d9badb6 into main Sep 22, 2023
2 checks passed
@astefanutti astefanutti deleted the pr-rbac-1.0.0-rc.1 branch September 22, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants