Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raytune_oai_mr_grpc_test test #287

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Dec 3, 2024

Description

Adjust S3 configuration and test termination condition to successfully test raytune-oai-MR-gRPC-demo.ipynb example.
Depends on project-codeflare/codeflare-common#83

How Has This Been Tested?

Manually by running against OCP.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@sutaakar sutaakar marked this pull request as ready for review December 3, 2024 14:10
@sutaakar sutaakar requested review from abhijeet-dhumal and ChughShilpa and removed request for Bobbins228 December 3, 2024 14:11
Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a3ff979 into opendatahub-io:main Dec 3, 2024
1 check passed
@sutaakar sutaakar deleted the raytune-fix branch December 4, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants