Defer retrieving GetRayJobId in test

[sutaakar]

GetRayJobId call needs to be deferred to make sure that job id is stored by KubeRay cluster.

Description

TestRayCluster test was failing on log storage line. Log storage function was deferred, however its arguments are resolved in realtime, causing GetRayJobId to be resolved before KubeRay operator had a chance to store job id in RayJob CR.

Moving the whole log storage line into separate function makes sure that RayJob CR is fully initialized.

How Has This Been Tested?

Manually.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[astefanutti]

/lgtm

[astefanutti]

That makes me think whether we should update the Ray API helper function signatures to take the Job namespace and name, instead of the Job id, and do the retrieval from within the helper function.

[winklerm]

/approve

[sutaakar]

That makes me think whether we should update the Ray API helper function signatures to take the Job namespace and name, instead of the Job id, and do the retrieval from within the helper function.

@astefanutti The problem is that there are two options of submitting the job - CR or REST API. In case of REST API there is no CR created, so helper wouldn't be able to obtain job id in that case from namespace and name.

[astefanutti]

That makes me think whether we should update the Ray API helper function signatures to take the Job namespace and name, instead of the Job id, and do the retrieval from within the helper function.

@astefanutti The problem is that there are two options of submitting the job - CR or REST API. In case of REST API there is no CR created, so helper wouldn't be able to obtain job id in that case from namespace and name.

Ah right. So we could (re-)add the WriteRayJobLogs function in ray.go that would handle the RayJob case, and delegate to WriteRayJobAPILogs in ray_api.go. WDYT?

[astefanutti]

/lgtm

[astefanutti]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, winklerm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [astefanutti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment