Skip to content
Code static analysis

Merge pull request #479 from opendatahub-io/temp-v1.9-branch-12072896670 #372

Sign in to view logs

Merge pull request #479 from opendatahub-io/temp-v1.9-branch-12072896670

Merge pull request #479 from opendatahub-io/temp-v1.9-branch-12072896670 #372

Triggered via push November 28, 2024 17:20
@atheo89atheo89
pushed 343990c
v1.9.0-5
Status Failure
Total duration 26s
Artifacts –

code-quality.yaml

on: push
Matrix: golangci-lint
Matrix: govulncheck
Fit to window
Zoom out
Zoom in

Annotations

20 errors
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller.go#L122
Error return value of `retry.OnError` is not checked (errcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_oauth.go#L193
Error return value of `rand.Read` is not checked (errcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_route.go#L47
SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_webhook.go#L190
SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_webhook.go#L213
SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller_test.go#L147
SA1019: pointer.BoolPtr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller_test.go#L148
SA1019: pointer.BoolPtr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller_test.go#L543
SA1019: pointer.BoolPtr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_route.go#L29
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_webhook.go#L38
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L137
S1033: unnecessary guard around call to delete (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L325
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.KernelStatus is defined as zero (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L362
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.TerminalStatus is defined as zero (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L346
S1039: unnecessary use of fmt.Sprintf (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L373
S1039: unnecessary use of fmt.Sprintf (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L266
SA5011: possible nil pointer dereference (staticcheck)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L267
SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller_test.go#L256
Error return value is not checked (errcheck)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller.go#L359
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.KernelStatus is defined as zero (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller.go#L395
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.TerminalStatus is defined as zero (gosimple)