RHOAIENG-7610: fix(nbc): deduplicate culling-related configmap keys #187
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Notebook Controller Integration Test | |
| on: | |
| push: | |
| pull_request: | |
| paths: | |
| - components/notebook-controller/** | |
| workflow_dispatch: | |
| env: | |
| IMG: notebook-controller | |
| TAG: integration-test | |
| jobs: | |
| build: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: Install podman | |
| run: | | |
| sudo mkdir -p /etc/apt/keyrings | |
| curl -fsSL https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/unstable/xUbuntu_$(lsb_release -rs)/Release.key \ | |
| | gpg --dearmor \ | |
| | sudo tee /etc/apt/keyrings/devel_kubic_libcontainers_unstable.gpg > /dev/null | |
| echo \ | |
| "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/devel_kubic_libcontainers_unstable.gpg]\ | |
| https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/unstable/xUbuntu_$(lsb_release -rs)/ /" \ | |
| | sudo tee /etc/apt/sources.list.d/devel:kubic:libcontainers:unstable.list > /dev/null | |
| sudo apt-get update -qq | |
| sudo apt-get -qq -y install podman | |
| podman version | |
| # temporary fix for https://github.com/containers/podman/issues/21024 | |
| wget https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/xUbuntu_22.04/amd64/conmon_2.1.2~0_amd64.deb -O /tmp/conmon_2.1.2.deb | |
| sudo apt install /tmp/conmon_2.1.2.deb | |
| # Starting systemd user service | |
| systemctl --user daemon-reload | |
| systemctl --user start podman.socket | |
| - name: Login to GitHub Container Registry | |
| uses: docker/login-action@v3 | |
| with: | |
| registry: ghcr.io | |
| username: ${{ github.actor }} | |
| password: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Install Go | |
| uses: actions/setup-go@v5 | |
| with: | |
| check-latest: true | |
| go-version-file: components/notebook-controller/go.mod | |
| cache-dependency-path: components/notebook-controller/go.sum | |
| - name: Build Notebook Controller Image | |
| run: | | |
| cd components/notebook-controller | |
| make docker-build | |
| env: | |
| CACHE_IMAGE: ghcr.io/${{ github.repository }}/components/notebook-controller/build-cache | |
| - name: Install KinD | |
| run: ./components/testing/gh-actions/install_kind.sh | |
| - name: Create KinD Cluster | |
| run: kind create cluster --config components/testing/gh-actions/kind-1-25.yaml | |
| - name: Load Images into KinD Cluster | |
| run: | | |
| # kind load docker-image localhost/${{env.IMG}}:${{env.TAG}} | |
| podman save -o img.tar localhost/${{env.IMG}}:${{env.TAG}} | |
| kind load image-archive img.tar | |
| - name: Install kustomize | |
| run: ./components/testing/gh-actions/install_kustomize.sh | |
| - name: Install Istio | |
| run: ./components/testing/gh-actions/install_istio.sh | |
| - name: Build & Apply manifests | |
| run: | | |
| set -x | |
| cd components/notebook-controller/config/overlays/kubeflow | |
| kubectl create ns kubeflow | |
| export CURRENT_NOTEBOOK_IMG=docker.io/kubeflownotebookswg/notebook-controller | |
| export PR_NOTEBOOK_IMG=localhost/${{env.IMG}}:${{env.TAG}} | |
| kustomize edit set image ${CURRENT_NOTEBOOK_IMG}=${PR_NOTEBOOK_IMG} | |
| cat <<EOF | kubectl apply -f - | |
| --- | |
| apiVersion: v1 | |
| kind: ConfigMap | |
| metadata: | |
| name: notebook-controller-culler-config | |
| namespace: kubeflow | |
| data: | |
| ENABLE_CULLING: "true" | |
| CULL_IDLE_TIME: "60" # In minutes (1 hour) | |
| IDLENESS_CHECK_PERIOD: "5" # In minutes | |
| EOF | |
| kustomize build . | sed 's/imagePullPolicy: Always/imagePullPolicy: IfNotPresent/g' | kubectl apply -f - | |
| kubectl wait pods -n kubeflow -l app=notebook-controller --for=condition=Ready --timeout=100s | |
| - name: Print logs | |
| if: "!cancelled()" | |
| run: | | |
| kubectl describe pods -n kubeflow -l app=notebook-controller | |
| kubectl logs -n kubeflow -l app=notebook-controller |