Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back GitHub Actions testing #302

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Bring back GitHub Actions testing #302

merged 1 commit into from
Apr 11, 2024

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Apr 2, 2024

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Apr 2, 2024

Hi @jiridanek. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* Delete .github/workflows we don't use in this fork

* Enable `notebook_controller_unit_test.yaml` action

* Update go version, otherwise much errors
@jiridanek jiridanek marked this pull request as ready for review April 8, 2024 13:31
@jiridanek
Copy link
Member Author

Here's the result of the GHA run. Currently, the test is failing, https://github.com/jiridanek/kubeflow/actions/runs/8600982629/job/23567132483#step:4:129

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x15fef9b]

goroutine 274 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
	/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:115 +0x1fa
panic({0x1771640, 0x28d0990})
	/opt/hostedtoolcache/go/1.19.13/x64/src/runtime/panic.go:884 +0x212

@rkpattnaik780
Copy link

/lgtm
/ok-to-test

@rkpattnaik780
Copy link

Here's the result of the GHA run. Currently, the test is failing, https://github.com/jiridanek/kubeflow/actions/runs/8600982629/job/23567132483#step:4:129

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x15fef9b]

goroutine 274 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
	/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:115 +0x1fa
panic({0x1771640, 0x28d0990})
	/opt/hostedtoolcache/go/1.19.13/x64/src/runtime/panic.go:884 +0x212

The error should be fixed in #309

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

Copy link

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ac76291 into opendatahub-io:v1.7-branch Apr 11, 2024
5 checks passed
@harshad16
Copy link
Member

/cherrypick stable

@openshift-cherrypick-robot

@harshad16: new pull request created: #317

In response to this:

/cherrypick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants