Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong imports in tests on stable branch caused by cherry-picking mistakes #320

Merged
merged 2 commits into from
May 10, 2024

Conversation

jiridanek
Copy link
Member

This has been introduced when cherry-picking https://github.com/opendatahub-io/kubeflow/pull/250/files#r1563972573 to stable

Description

How Has This Been Tested?

GitHub Actions now pass

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Apr 13, 2024

Hi @jiridanek. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiridanek jiridanek changed the title Remove one unused and one duplicated in notebook_controller_test.go Fix wrong imports on stable branch caused by cherry-picking mistakes Apr 13, 2024
@jiridanek jiridanek changed the title Fix wrong imports on stable branch caused by cherry-picking mistakes Fix wrong imports in tests on stable branch caused by cherry-picking mistakes Apr 13, 2024
@harshad16 harshad16 requested review from rkpattnaik780 and removed request for LaVLaS and VaishnaviHire April 18, 2024 02:56
@harshad16
Copy link
Member

/assign @rkpattnaik780

@harshad16
Copy link
Member

/ok-to-test

Copy link

@rkpattnaik780 rkpattnaik780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 18, 2024
@harshad16
Copy link
Member

/lgtm
/approve

thanks for the work 💯

Copy link

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, rkpattnaik780

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 6, 2024
@jiridanek
Copy link
Member Author

@harshad16 looks like this won't automerge

tide Pending — Not mergeable. No Tide query for branch stable found.

@harshad16 harshad16 merged commit a5c807f into opendatahub-io:stable May 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants