Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: fix(gha) improve robustness by checking for resource existence #418

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Oct 15, 2024

Depends on

Description

Without this, the gha is flaky and may fail with

notebook.kubeflow.org/minimal-notebook created
Error from server (NotFound): statefulsets.apps "minimal-notebook" not found

How Has This Been Tested?

GHA

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Oct 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Without this, the gha is flaky and may fail with

```
notebook.kubeflow.org/minimal-notebook created
Error from server (NotFound): statefulsets.apps "minimal-notebook" not found
```
@jiridanek
Copy link
Member Author

No objections after quite a long time, so it should be good to go. Let's do it the Apache way, commit-then-review. https://www.apache.org/foundation/glossary#CommitThenReview

/lgtm
/approve

Copy link

openshift-ci bot commented Oct 16, 2024

@jiridanek: you cannot LGTM your own PR.

In response to this:

No objections after quite a long time, so it should be good to go. Let's do it the Apache way, commit-then-review. https://www.apache.org/foundation/glossary#CommitThenReview

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek jiridanek added the lgtm label Oct 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 130d758 into opendatahub-io:main Oct 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant