[GHA-12159560062] Update odh and notebook-controller with image 1.9-343990c

[github-actions]

🤖 This is an automated Pull Request created by /.github/workflows/notebook-controller-images-updater.yaml.

Have been updated the following related files:

• components/notebook-controller/config/overlays/openshift/params.env
• components/odh-notebook-controller/config/base/params.env
• components/odh-notebook-controller/makefile-vars.mk

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign harshad16 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[atheo89]

It doesn't seem that the GHAs fired when the PR is created by github bot... this is the commit that enable them on v1.9-branch: 9116a09

In contrary, if a user close and reopen the this PR then the GHA fired. 🤔

[atheo89]

/ok-to-test

[atheo89]

The /ok-to-test fires only the prow tests

[jstourac]

It doesn't seem that the GHAs fired when the PR is created by github bot... this is the commit that enable them on v1.9-branch: 9116a09

In contrary, if a user close and reopen the this PR then the GHA fired. 🤔

@atheo89 I think that this is the reason: https://github.com/orgs/community/discussions/65321

[atheo89]

It doesn't seem that the GHAs fired when the PR is created by github bot... this is the commit that enable them on v1.9-branch: 9116a09
In contrary, if a user close and reopen the this PR then the GHA fired. 🤔

@atheo89 I think that this is the reason: https://github.com/orgs/community/discussions/65321

Thank you Jan! That's it! I tested locally to generate a token with workflow related scopes and it work fine. I have the tests on the generated PR: atheo89#89

[atheo89]

After discussion on the scrum we can not use personal access tokens so the decision is to go using a member account dedicated for the IDE team, or if there is availble bot app under odh-io, to provide secret token for us.

Refs:
[1] https://issues.redhat.com/browse/RHOAIENG-16580
[2] https://redhat-internal.slack.com/archives/C05NXTEHLGY/p1733389810441629