NO-ISSUE: chore(gha): run tests in a gha when gha itself is modified in a pr

[jiridanek]

Description

This is a followup to a previous pr that added this to .github/workflows/odh_notebook_controller_integration_test.yaml odh-notebook-controller integration tests already

• RHOAIENG-9824: gha(odh-nbc): improve the GitHub Actions integration test for odh-notebook-controller to start the controller successfully and run a notebook #398

How Has This Been Tested?

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[caponetto]

/lgtm

[jiridanek]

/approve

second pair of eyes ofc welcome

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jiridanek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyatmiami]

/lgtm

was originally confused about why the .github/workflows/odh_notebook_controller_integration_test.yaml file was not modified in this PR - but it is due to the fact the necessary paths: entry is already present 💯

[jiridanek]

ocp-ci is kaput, let's try one more time

/retest-required

[jstourac]

/override ci/prow/odh-notebook-controller-e2e

The changes in this PR are irrelevant to the e2e tests results, though - there may be something fishy there in our code or env as 3 tests failed:

=== RUN   TestE2ENotebookController/create/thoth-minimal-oauth-notebook/Notebook_Statefulset_Validation
    notebook_creation_test.go:49: 
        	Error Trace:	/go/src/github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/e2e/notebook_creation_test.go:49
        	Error:      	Received unexpected error:
        	            	error validating notebook StatefulSet: timed out waiting for the condition
        	Test:       	TestE2ENotebookController/create/thoth-minimal-oauth-notebook/Notebook_Statefulset_Validation
        	Messages:   	error testing StatefulSet for Notebook 
=== RUN   TestE2ENotebookController/create/thoth-minimal-oauth-notebook/Notebook_OAuth_sidecar_Validation
    notebook_creation_test.go:57: 
        	Error Trace:	/go/src/github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/e2e/notebook_creation_test.go:57
        	Error:      	Received unexpected error:
        	            	notebook pod thoth-minimal-oauth-notebook-0 is not in Running phase
        	Test:       	TestE2ENotebookController/create/thoth-minimal-oauth-notebook/Notebook_OAuth_sidecar_Validation
        	Messages:   	error testing sidecar for Notebook 
=== RUN   TestE2ENotebookController/create/thoth-minimal-oauth-notebook/Verify_Notebook_Traffic
    notebook_creation_test.go:62: 
        	Error Trace:	/go/src/github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/e2e/notebook_creation_test.go:62
        	Error:      	Received unexpected error:
        	            	unexpected response from Notebook Endpoint:
        	            	HTTP/1.0 503 Service Unavailable
        	            	Connection: close
        	            	Cache-Control: private, max-age=0, no-cache, no-store
        	            	Content-Type: text/html
        	            	Pragma: no-cache
        	            	
        	Test:       	TestE2ENotebookController/create/thoth-minimal-oauth-notebook/Verify_Notebook_Traffic
        	Messages:   	error testing Notebook traffic

[openshift-ci]

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/odh-notebook-controller-e2e

In response to this:

/override ci/prow/odh-notebook-controller-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.