Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ubi base images #4

Closed
wants to merge 2 commits into from

Conversation

dimakis
Copy link

@dimakis dimakis commented Oct 18, 2023

Why are these changes needed?

Related issue number

Closes project-codeflare/codeflare-operator#351

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@dimakis dimakis requested a review from tedhtchang October 18, 2023 08:55
@dimakis
Copy link
Author

dimakis commented Oct 18, 2023

@astefanutti @anishasthana

Signed-off-by: Dimitri Saridakis <[email protected]>
Copy link
Member

@tedhtchang tedhtchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimakis The tag 1.19 points to a newest 1.19.13-2 at the moment but may point to another newer version later without passing the CI tests. Is this the behavior you want ?

@astefanutti
Copy link

@tedhtchang I agree using a non-rolling tag would be useful so we have reproducible builds. So maybe @dimakis you can use the 1.19.13-2 tag. On the other hand, this is a temporary patch anyway, as it'll be superseded by the changes from upstream ray-project#1540 once that fork is rebased.

@anishasthana
Copy link
Member

I'd like to think about the versioning/branching a little bit before we merge this.

@dimakis dimakis closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UBI base images for ODH KubeRay
4 participants