Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVE fixes e2e jan5 #9

Merged
merged 3 commits into from
Jan 5, 2024
Merged

CVE fixes e2e jan5 #9

merged 3 commits into from
Jan 5, 2024

Conversation

ChristianZaccaria
Copy link

Why are these changes needed?

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

astefanutti
astefanutti reviewed Jan 5, 2024
View reviewed changes
Copy link

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think these patches can be actually labeled as drops?

Also, could the go mod tidy patch be squashed atomically with the patch that requires it?

@astefanutti astefanutti merged commit 742adbc into opendatahub-io:master Jan 5, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianZaccaria @astefanutti